-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support scheduler_plugin_execution_duration_seconds
in scheduler_perf
#124578
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
sanposhiho:scheduler_perf_scheduler_plugin_execution_duration_seconds
May 5, 2024
+188
−15
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
/* | ||
Copyright 2015 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package benchmark | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
) | ||
|
||
func Test_uniqueLVCombos(t *testing.T) { | ||
type args struct { | ||
lvs []*labelValues | ||
} | ||
tests := []struct { | ||
name string | ||
args args | ||
want []map[string]string | ||
}{ | ||
{ | ||
name: "empty input", | ||
args: args{ | ||
lvs: []*labelValues{}, | ||
}, | ||
want: []map[string]string{{}}, | ||
}, | ||
{ | ||
name: "single label, multiple values", | ||
args: args{ | ||
lvs: []*labelValues{ | ||
{"A", []string{"a1", "a2"}}, | ||
}, | ||
}, | ||
want: []map[string]string{ | ||
{"A": "a1"}, | ||
{"A": "a2"}, | ||
}, | ||
}, | ||
{ | ||
name: "multiple labels, single value each", | ||
args: args{ | ||
lvs: []*labelValues{ | ||
{"A", []string{"a1"}}, | ||
{"B", []string{"b1"}}, | ||
}, | ||
}, | ||
want: []map[string]string{ | ||
{"A": "a1", "B": "b1"}, | ||
}, | ||
}, | ||
{ | ||
name: "multiple labels, multiple values", | ||
args: args{ | ||
lvs: []*labelValues{ | ||
{"A", []string{"a1", "a2"}}, | ||
{"B", []string{"b1", "b2"}}, | ||
}, | ||
}, | ||
want: []map[string]string{ | ||
{"A": "a1", "B": "b1"}, | ||
{"A": "a1", "B": "b2"}, | ||
{"A": "a2", "B": "b1"}, | ||
{"A": "a2", "B": "b2"}, | ||
}, | ||
}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
if got := uniqueLVCombos(tt.args.lvs); !reflect.DeepEqual(got, tt.want) { | ||
t.Errorf("uniqueLVCombos() = %v, want %v", got, tt.want) | ||
} | ||
}) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the metrics in scheduler-perf are under control like other metrics. It means we should list stable metrics.
https://kubernetes.io/docs/reference/instrumentation/metrics/#list-of-stable-kubernetes-metrics
WDYT? @logicalhan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit out of responsibility in this PR, but let me ask you a question for our future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we're going to be able to parse this file..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks... challenging from a static analysis perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I don't understand what @utam0k means. Why should we in the first place actually?
All metrics used in scheduler_perf are existing metrics that are exposed from scheduler, not something like scheduler_perf's original metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you are right.