-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all-pods log flag to kubectl #124732
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @cmwylie19. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
@aojea any idea why the tests would be failing like this? The test runs fine locally but is hitting the 10 minute timeout while trying to spin up a StatefulSet. It looks like it manages to get 1 pod up at one point but then falls back to 0. |
It looks like both StatefulSets were actually created and logged out successfully |
083b9a1
to
d699212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change then lgtm!
/approve
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this!
/lgtm
LGTM label has been added. Git tree hash: f06afdfd7c71bd6719291a0312fd93b34d434dcc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cmwylie19, eddiezane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(this happens all the time, making e2e tests reliable is hard, but if I'm right and it is this test it would be appreciated to investigate and attempt to increase e2e test reliability 🙏 , at a quick glance nothing jumps out in the test code) |
Spoke with Ben. Going to submit something. |
What type of PR is this?
/kind feature
ref: #123874
What this PR does / why we need it:
This adds an
--all-pods
option to get all pod logs from replicaSets or services by looking at the label selector and finding corresponding pods in the namespace. It reduces the need to look for logs based on labels.Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#1520
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
usage