Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flake] Fix test in kubectl logs all pods #125037

Merged
merged 1 commit into from
May 22, 2024
Merged

[Flake] Fix test in kubectl logs all pods #125037

merged 1 commit into from
May 22, 2024

Conversation

eddiezane
Copy link
Member

What type of PR is this?

/kind flake

What this PR does / why we need it:

This PR prevents the pods from completing until the assertions can be run.

Which issue(s) this PR fixes:

ref: #124732 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cli
/cc @BenTheElder

@eddiezane
Prevent pods from completing before test runs
411e009 
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, eddiezane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brianpursley
Copy link
Member

/lgtm
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 22, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 448003cab323e1bcadc79f01c8bf2a27b1d6c748

@k8s-ci-robot k8s-ci-robot merged commit cabdf39 into kubernetes:master May 22, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 22, 2024
@eddiezane eddiezane deleted the ez/fix-logs-flake branch May 22, 2024 00:10
@eddiezane
Copy link
Member Author

I've got a reminder set to check this in 2 days

https://storage.googleapis.com/k8s-triage/index.html?test=Kubectl%20logs%20all%20pod%20logs%20the%20Deployment%20has%202%20replicas%20

@BenTheElder BenTheElder mentioned this pull request May 22, 2024
Merged
@eddiezane
Copy link
Member Author

Calling this solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddiezane @k8s-ci-robot @brianpursley