Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote HonorPVReclaimPolicy to beta and enable it by default #124842

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

e2e tests was added by #123151

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/hold
for kubernetes/enhancements#4397 and kubernetes-csi/external-provisioner#1209 to be merged

Does this PR introduce a user-facing change?

Promote HonorPVReclaimPolicy to beta and enable the feature-gate by default

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2644

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 13, 2024
@carlory
Copy link
Member Author

carlory commented May 13, 2024

/test pull-kubernetes-unit

@carlory
Copy link
Member Author

carlory commented May 16, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
@carlory carlory force-pushed the honor-pv-reclaim-policy-e2e branch from 3c88ddb to 6321602 Compare May 16, 2024 02:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
@carlory carlory force-pushed the honor-pv-reclaim-policy-e2e branch from 6321602 to 1cf6cca Compare May 16, 2024 02:42
@carlory
Copy link
Member Author

carlory commented May 16, 2024

/cc @xing-yang @deepakkinni

@xing-yang
Copy link
Contributor

@carlory Since both PRs are merged, we don't need to hold this PR any more. Can you please take a look at the CI failure?

@carlory
Copy link
Member Author

carlory commented Jun 6, 2024

/test pull-kubernetes-e2e-gce-storage-snapshot

@carlory
Copy link
Member Author

carlory commented Jun 6, 2024

@xing-yang Before we promote it, do we need to update hostpath manifests under the e2e directory? If needed, the hostpath driver needs to cut a release.

@xing-yang
Copy link
Contributor

@carlory I'll cut a release after this PR is merged: kubernetes-csi/csi-driver-host-path#532

@carlory carlory force-pushed the honor-pv-reclaim-policy-e2e branch from 1cf6cca to 85cba53 Compare June 19, 2024 02:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2024
@carlory carlory force-pushed the honor-pv-reclaim-policy-e2e branch 2 times, most recently from bfcf6a1 to 010624d Compare June 19, 2024 02:49
@carlory
Copy link
Member Author

carlory commented Jun 19, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@carlory
Copy link
Member Author

carlory commented Jun 19, 2024

/hold

util kubernetes-csi/csi-driver-host-path#537 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@carlory carlory force-pushed the honor-pv-reclaim-policy-e2e branch from 010624d to 4058178 Compare June 19, 2024 05:51
@carlory
Copy link
Member Author

carlory commented Jun 19, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@carlory
Copy link
Member Author

carlory commented Jun 19, 2024

/test pull-kubernetes-unit

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a7d7a56c4312aaa63b865862dd9b0a78c52c364

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit aeed1d0 into kubernetes:master Jun 19, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 19, 2024
@carlory carlory deleted the honor-pv-reclaim-policy-e2e branch June 20, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants