-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote HonorPVReclaimPolicy to beta and enable it by default #124842
Promote HonorPVReclaimPolicy to beta and enable it by default #124842
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-kubernetes-unit |
/sig storage |
3c88ddb
to
6321602
Compare
6321602
to
1cf6cca
Compare
@carlory Since both PRs are merged, we don't need to hold this PR any more. Can you please take a look at the CI failure? |
/test pull-kubernetes-e2e-gce-storage-snapshot |
@xing-yang Before we promote it, do we need to update hostpath manifests under the e2e directory? If needed, the hostpath driver needs to cut a release. |
@carlory I'll cut a release after this PR is merged: kubernetes-csi/csi-driver-host-path#532 |
1cf6cca
to
85cba53
Compare
bfcf6a1
to
010624d
Compare
/hold cancel |
/hold util kubernetes-csi/csi-driver-host-path#537 is merged |
010624d
to
4058178
Compare
/hold cancel |
/test pull-kubernetes-unit |
/lgtm |
LGTM label has been added. Git tree hash: 8a7d7a56c4312aaa63b865862dd9b0a78c52c364
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
e2e tests was added by #123151
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/hold
for kubernetes/enhancements#4397 and kubernetes-csi/external-provisioner#1209 to be merged
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: