Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests: Enables should test kubelet managed /etc/hosts file for Windows #124852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

e2e tests: Enables should test kubelet managed /etc/hosts file for Windows #124852

wants to merge 1 commit into from
+20 −10

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented May 13, 2024 •
edited
Loading

What type of PR is this?

/kind failing-test
/sig testing
/sig windows

What this PR does / why we need it:

We previously skipped this test because Docker did not support mounting individual files in Containers.

Since then, support for Docker has been removed, and containerd on Windows supports this feature. We can run this test on Windows.

Which issue(s) this PR fixes:

Related ##124426

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@pacoxu pacoxu added this to Triage in SIG Node PR Triage May 14, 2024
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels May 14, 2024
@claudiubelu claudiubelu changed the title WIP: e2e tests: Enables should test kubelet managed /etc/hosts file for Wi… WIP: e2e tests: Enables should test kubelet managed /etc/hosts file for Windows May 14, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2024
@claudiubelu claudiubelu changed the title WIP: e2e tests: Enables should test kubelet managed /etc/hosts file for Windows e2e tests: Enables should test kubelet managed /etc/hosts file for Windows May 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@claudiubelu claudiubelu mentioned this pull request May 14, 2024
Open
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2024
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage May 15, 2024
@bart0sh
Copy link
Contributor

bart0sh commented May 15, 2024

/kind failing-test

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 15, 2024
@claudiubelu
e2e tests: Enables should test kubelet managed /etc/hosts file for Wi…
844426f 
…ndows

We previously skipped this test because Docker did not support mounting
individual files in Containers.

Since then, support for Docker has been removed, and containerd on Windows
supports this feature. We can run this test on Windows.
@bart0sh
Copy link
Contributor

bart0sh commented May 31, 2024

/lgtm
/cc @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1303fbdbf356db974335c231b53bedbf9eda67b

@claudiubelu
Copy link
Contributor Author

/assign @Random-Liu @smarterclayton

@pacoxu pacoxu moved this from PRs Waiting on Author to PRs - Needs Approver in SIG Node CI/Test Board MIGRATED-use https://github.com/orgs/kubernetes/projects/151 Jun 25, 2024
@pacoxu
Copy link
Member

pacoxu commented Jun 25, 2024

/assign @kubernetes/cncf-conformance-wg @johnbelamaric @dims
for conformance-behavior part

@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-e2e-capz-windows-master

1 similar comment
@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-e2e-capz-windows-master

SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a general rule we are promoting to Conformance after it was running as non-confirmance for a while. I cannot find the official policy quickly.

In this case changes are quite straightforward, we may want to take an exception here. Test is passing in /test pull-kubernetes-e2e-capz-windows-master.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: claudiubelu, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please ask for approval from smarterclayton. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Jul 24, 2024

/assign @dims
for conformance

@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-e2e-capz-windows-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh bart0sh left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@kannon92 kannon92 Awaiting requested review from kannon92

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@dims dims

@smarterclayton smarterclayton

@Random-Liu Random-Liu

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Status: Needs Approver
SIG Node CI/Test Board MIGRATED-use h...
PRs - Needs Approver
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@claudiubelu @bart0sh @k8s-ci-robot @pacoxu @SergeyKanzhelev @dims @smarterclayton @Random-Liu