Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove legacycloudproviders from staging" #124864

Merged
merged 1 commit into from
May 14, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 14, 2024

This reverts commit 07c8d35.

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

The publishing bot doesn't support to remove the master rule from the staging directory when the repository is being used by supported releases. so I have to revert the changes made by #124862 in order to not break the pull-publishing-bot-validate job, see #124829.

The reverted PR is expected to be merged after 1.30 goes out of support. I add a to-do item to #124771 to remind us to do so.

Which issue(s) this PR fixes:

Ref #124829
Ref #124862

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Revert "remove legacycloudproviders from staging"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. area/dependency Issues or PRs related to dependency changes labels May 14, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and a team May 14, 2024 05:54
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 14, 2024
@carlory
Copy link
Member Author

carlory commented May 14, 2024

/hold
waiting a feedback.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@carlory
Copy link
Member Author

carlory commented May 14, 2024

/test pull-kubernetes-e2e-gce

@pacoxu
Copy link
Member

pacoxu commented May 14, 2024

/retest
/approve
/lgtm
for #124861 and kubernetes/publishing-bot#433
/assign @saschagrunert @dims

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2948e9880dac898266eb8aa21445507091a0cdaa

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 14, 2024

@carlory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-publishing-bot-validate d9a0be3 link false /test pull-publishing-bot-validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Member

/skip

That pull-publishing-bot-validate fails is intentional since it does not exist any more.

@dims
Copy link
Member

dims commented May 14, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, dims, pacoxu, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@carlory
Copy link
Member Author

carlory commented May 14, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0df6f45 into kubernetes:master May 14, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants