-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "remove legacycloudproviders from staging" #124864
Conversation
This reverts commit 07c8d35.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold |
/test pull-kubernetes-e2e-gce |
/retest |
LGTM label has been added. Git tree hash: 2948e9880dac898266eb8aa21445507091a0cdaa
|
@carlory: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/skip That pull-publishing-bot-validate fails is intentional since it does not exist any more. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, dims, pacoxu, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
This reverts commit 07c8d35.
What type of PR is this?
/kind bug
/kind failing-test
/kind regression
What this PR does / why we need it:
The publishing bot doesn't support to remove the master rule from the staging directory when the repository is being used by supported releases. so I have to revert the changes made by #124862 in order to not break the
pull-publishing-bot-validate
job, see #124829.The reverted PR is expected to be merged after 1.30 goes out of support. I add a to-do item to #124771 to remind us to do so.
Which issue(s) this PR fixes:
Ref #124829
Ref #124862
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: