Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance rules.yaml release branch validation to decouple from changes in k/k master #433

Closed
saschagrunert opened this issue May 14, 2024 · 2 comments · Fixed by #434
Closed

Enhance rules.yaml release branch validation to decouple from changes in k/k master #433

saschagrunert opened this issue May 14, 2024 · 2 comments · Fixed by #434

Comments

@saschagrunert
Copy link
Member

Issue

We removed the legacy-cloud-providers staging repo in kubernetes/kubernetes#124767 on k/k master, which immediately broke the rule validation (pull-publishing-bot-validate) for all supported release branches.

Solution

  • We only validate the rules for the actual release branch when running on a release-x.y branch.
  • Continue to validate all rules when running on master

cc @kubernetes/release-engineering
@saschagrunert saschagrunert mentioned this issue May 14, 2024
Closed
@saschagrunert saschagrunert changed the title Only validate rules.yaml release branch when running on one Only validate rules.yaml for release branches when running on one May 14, 2024
@saschagrunert saschagrunert changed the title Only validate rules.yaml for release branches when running on one Enhance rules.yaml release branch validation to decouple from changes on k/k master May 14, 2024
@saschagrunert saschagrunert changed the title Enhance rules.yaml release branch validation to decouple from changes on k/k master Enhance rules.yaml release branch validation to decouple from changes in k/k master May 14, 2024
@carlory carlory mentioned this issue May 14, 2024
Open
@pacoxu pacoxu mentioned this issue May 14, 2024
Merged
@cpanato
Copy link
Member

cpanato commented May 14, 2024

sounds good to me this approach

saschagrunert added a commit to saschagrunert/publishing-bot that referenced this issue May 14, 2024
@saschagrunert
Use PULL_BASE_REF for branch rules validation
68ab8b4 
We now consider the `PULL_BASE_REF` (can be empty) to:

- Check all rules when running on `master`
- Check only branch specific rules for release branches

Fixes kubernetes#433

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue May 14, 2024
Merged
@saschagrunert
Copy link
Member Author

It works: https://prow.k8s.io/log?container=test&id=1790378501673586688&job=pull-publishing-bot-validate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use PULL_BASE_REF for branch rules validation saschagrunert/publishing-bot
2 participants
@saschagrunert @cpanato