Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed flaky test TestLog/stateful_set_logs_with_all_pods by splitting expected output string #125049

Merged
merged 1 commit into from
May 22, 2024
Merged

fixed flaky test TestLog/stateful_set_logs_with_all_pods by splitting expected output string #125049

merged 1 commit into from
May 22, 2024

Conversation

srivastav-abhishek
Copy link
Contributor

What type of PR is this?

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #125048

Special notes for your reviewer:

Fixed test TestLog/stateful_set_logs_with_all_pods by splitting expected o/p string to accommodate situations where in Pod1 logs are present before Pod0 in buffer.

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @srivastav-abhishek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@srivastav-abhishek
Copy link
Contributor Author

srivastav-abhishek commented May 22, 2024 •
edited

/cc @Rajalakshmi-Girish @mkumatag @eddiezane

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 22, 2024
@srivastav-abhishek srivastav-abhishek changed the title fixed flaky test by splitting expected output string fixed flaky test TestLog/stateful_set_logs_with_all_pods by splitting expected output string May 22, 2024
@eddiezane
Copy link
Member

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2024
eddiezane
eddiezane suggested changes May 22, 2024
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Clean up request then lgtm.

/approve

staging/src/k8s.io/kubectl/pkg/cmd/logs/logs_test.go Outdated
@@ -117,7 +117,7 @@ func TestLog(t *testing.T) {
o.Prefix = true
return o
},
expectedOutSubstrings: []string{"[pod/test-sts-0/test-container] test log content for pod test-sts-0\n[pod/test-sts-1/test-container] test log content for pod test-sts-1\n"},
expectedOutSubstrings: []string{"[pod/test-sts-0/test-container] test log content for pod test-sts-0\n", "[pod/test-sts-1/test-container] test log content for pod test-sts-1\n"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expectedOutSubstrings: []string{"[pod/test-sts-0/test-container] test log content for pod test-sts-0\n", "[pod/test-sts-1/test-container] test log content for pod test-sts-1\n"},
expectedOutSubstrings: []string{
"[pod/test-sts-0/test-container] test log content for pod test-sts-0\n",
"[pod/test-sts-1/test-container] test log content for pod test-sts-1\n",
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks !

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
eddiezane
eddiezane approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bd76db2a4f924ccd77f3334774c653d5295ea067

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, srivastav-abhishek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 84a7f1e into kubernetes:master May 22, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 22, 2024
@srivastav-abhishek srivastav-abhishek deleted the flake-fix-logs-test branch May 23, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees

@eddiezane eddiezane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG CLI
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

[Flaking Test] TestLog/stateful_set_logs_with_all_pods
3 participants
@srivastav-abhishek @k8s-ci-robot @eddiezane