-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4222: Add unit tests for decoding CBOR into interface{} type #125068
Conversation
Co-authored-by: Ben Luddy <bluddy@redhat.com>
the organization helps /lgtm |
LGTM label has been added. Git tree hash: 83c428131c156cefbcbbf6640bfb79b43e8d6d32
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@benluddy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
/triage accepted |
What type of PR is this?
/kind cleanup
/sig api-machinery
What this PR does / why we need it:
Existing code assumes that decoding into Unstructured produces a
map[string]interface{}
containing values that are eitherinterface{}(nil)
or have one of the dynamic typesbool
,string
,int64
,float64
,[]interface{}
, ormap[string]interface{}
. The same assumption applies recursively to any[]interface{}
ormap[string]interface{}
.This PR adds tests that cover unmarshaling a wide range of potential CBOR inputs into
interface{}
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This continues the work started by @ssuriyan7 in #123546.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: