-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing "version" file in release tarballs #125076
Add missing "version" file in release tarballs #125076
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @BenTheElder @jeremyrickard @aojea |
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
yeah this is super useful, we should probably include a release note to let people know they can start using this?
LGTM label has been added. Git tree hash: ca37bb20d6bc1d166db67d57fc7c25fcd4cc3a93
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
In
package_final_tarball
we generate aversion
file here:kubernetes/build/lib/release.sh
Line 531 in 5cdab88
But in
package_node_tarballs
andpackage_server_tarballs
we missed doing the same. It's very handy to be able to crack open the tar.gz and immediately tell what the version was cut from, so let's please add it there as well./sig release
/sig testing
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: