Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ginkgo --label-filter extensions #125100

Closed
wants to merge 4 commits into from

Commits on May 22, 2024

  1. dependencies: ginkgo v2.18.0, gomega v1.33.1

    The most interesting aspect of the new Ginkgo is tweaking the output so that
    it's easier to follow while a job runs in
    Prow (onsi/ginkgo#1347). Using this in
    hack/ginkgo-e2e.sh will follow in a separate commit.
    
    Gomega gets bumped to the latest release to keep it up-to-date.
    
    The latest pprof added an indirect dependency on github.com/mailru/easyjson
    when adding a complex integration test. This does not affect Kubernetes and
    thus can be ignored.
    pohly committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b03ecba View commit details
    Browse the repository at this point in the history
  2. hack/ginkgo-e2e.sh: skip S character by default, add newlines in CI

    We typically have plenty of skipped tests in an E2E run, which causes Ginkgo to
    print many S characters (one for each skipped test). This easily fills up an entire
    console window. Now the default is to silence that
    output. GINKGO_SILENCE_SKIPS=n reverts to the previous behavior.
    
    By default, Ginkgo prints all progress characters (S and o) in a single
    line. Buffering in Prow causes that output to occur only after the run is over,
    which defeats the purpose of having those characters. Now a newline is added
    after each character, so there is visible progress in Prow while Ginkgo runs.
    pohly committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a892c3b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. WIP: ginkgo

    pohly committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c88674d View commit details
    Browse the repository at this point in the history
  2. e2e framework: don't add skip strings when user used --label-filter

    When the user manually sets either focus, skip or (new!) label filter, then the
    framework should not interfere and add the default skip strings.
    pohly committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6d2f075 View commit details
    Browse the repository at this point in the history