WIP: ginkgo --label-filter extensions #125100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most interesting aspect of the new Ginkgo is tweaking the output so that it's easier to follow while a job runs in Prow (onsi/ginkgo#1347). Using this in hack/ginkgo-e2e.sh will follow in a separate commit. Gomega gets bumped to the latest release to keep it up-to-date. The latest pprof added an indirect dependency on github.com/mailru/easyjson when adding a complex integration test. This does not affect Kubernetes and thus can be ignored.
We typically have plenty of skipped tests in an E2E run, which causes Ginkgo to print many S characters (one for each skipped test). This easily fills up an entire console window. Now the default is to silence that output. GINKGO_SILENCE_SKIPS=n reverts to the previous behavior. By default, Ginkgo prints all progress characters (S and o) in a single line. Buffering in Prow causes that output to occur only after the run is over, which defeats the purpose of having those characters. Now a newline is added after each character, so there is visible progress in Prow while Ginkgo runs.
When the user manually sets either focus, skip or (new!) label filter, then the framework should not interfere and add the default skip strings.
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-priority
3 tasks
k8s-ci-robot
added
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
k8s-ci-robot
added
sig/cli
|
@pohly: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
SergeyKanzhelev
moved this from Triage
to PRs Waiting on Author
in SIG Node CI/Test Board
This was referenced Jun 12, 2024
|
Superseded by #125045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This makes it possible to use --label-filter with an extended syntax for set labels like
Feature.Does this PR introduce a user-facing change?