Add load balancing support to services. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ae349c9905482af0e017345b86c7
…1fb7613c7cf1fe5e6567e02a9b2
…c5644976d13cadc67b285e73ee8
|
Hm, I see some binary files and .hg directories from dependencies. Is it a problem for the next person to re-get if we add them to .gitignore? |
|
Ok, addressed comments, removed the .hg files, cleaned things up. I think its all set now. PTAL |
|
(note I still need to add unit tests, so don't merge. Once there's LGTM, I'll add tests.) |
|
LGTM now. One nit, cloudprovider.CloudInterface could be named just cloudprovider.Interface. |
|
Comments addressed. Tests added. Ready to merge when you're ready. |
lavalamp
added a commit
that referenced
this pull request
Jun 18, 2014
Add load balancing support to services.
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
manage dependencies with godep
iaguis
pushed a commit
to kinvolk/kubernetes
that referenced
this pull request
Feb 6, 2018
Add CAP_NET_BIND_SERVICE to hyperkube.
marun
added a commit
to marun/kubernetes
that referenced
this pull request
Jun 4, 2020
Merging to enable rehearsal testing via openshift/release#9448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.