-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer documentation on e2e testing. #14112
Conversation
GCE e2e build/test passed for commit d8253a2c6399d802da66487793a8014a7774ddee. |
GCE e2e build/test passed for commit 8feb9fadc887f4f904c3e912c73c52f5b6a9a9a8. |
|
||
For a good overview of how we analyze performance data, please read the following [post](http://blog.kubernetes.io/2015/09/kubernetes-performance-measurements-and.html) | ||
|
||
Developers who are interested in doing their own performance analysis, we recommend setting up [prometheus](http://prometheus.io/) for data collection, and using [promdash](http://prometheus.io/docs/visualization/promdash/) to visualize the data. There also exists the option of pushing your own metrics in from the tests using a [prom-push-gateway](http://prometheus.io/docs/instrumenting/pushing/). Containers for all of these components can be found [here](https://hub.docker.com/u/prom/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Develeopers/For developers
Good tutorial, some minor ideas/comments, also pinged jon cope on it offline, who is a typical audience for this doc. Overall LGTM to me and good to merge as first iteration. |
I'll wait for other comments, then change in bulk. |
Labelling this PR as size/L |
Labelling this PR as size/L |
GCE e2e build/test failed for commit acb417f6736c6f310ec56dc9d6f912a584872c69. |
GCE e2e build/test passed for commit f958daf. |
@timothysc You should add a link to this from the api-changes doc; there's text about needing to write this doc in that one. |
@pmorie happy to do a follow on PR for links + cleanup. |
@eparis Either the bot is super slow, or label magic has shifted yet again ... ? |
Automatic merge from submit-queue |
Auto commit by PR queue bot
I just tried this and I am getting the following error:
The command I ran is:
I have a local cluster up which is fine. What am I missing? |
ah ! provide the kubeconfig file, it can be empty :)
I created #14355 so that this doesn't bother us anymore when doing local testing. |
@nikhiljindal you never specified your --kubeconfig which was denoted in the docs. |
(cc @ixdy @quinton-hoole) Just saw this PR; thanks for these docs @timothysc! It seems, though, to contradict some of the information in development.md. It also doesn't look like it accurately reflects how we run tests in Jenkins. Was there discussion about removing, linking, or changing existing documentation, and how to keep this from drifting with what we do in Jenkins? |
@ihmccreery This is developer oriented so it will certainly be different then the details re: Jenkins. I did that on purpose b/c upstreams scripts etc are prescriptive, while the details here are general to developer running locally. We also automate our testing very differently as well. At some point we should unify that process, but imho separate doc. |
Cool, thanks. Any thoughts on combining or removing content in development.md? |
@ihmccreery I think it's fine to keep the content, but just add a link to this one. |
Yeah, I missed this PR when it went by. There is some important setup that's done by Eventually I'd like to fold much of the functionality from |
... all that said, I really appreciate you writing documentation for this process! I'll try to take a look tomorrow at this doc and give specific feedback on things where our process differs a bit with yours. |
Auto commit by PR queue bot
Add developer documentation for e2e testing, such that Q/E and other folks can leverage.
/cc @eparis @pmorie @jayunit100