Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetReference() #1475

Merged
merged 1 commit into from
Sep 29, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 52 additions & 0 deletions pkg/api/ref.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
Copyright 2014 Google Inc. All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package api

import (
"fmt"
"regexp"

"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
)

var versionFromSelfLink = regexp.MustCompile("/api/([^/]*)/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems questionable given that we allow flexible path prefixes in the client and apiserver today. If we're going to do this we need to disallow that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let me file an issue to disallow flexible path prefixes or have another way to retrieve version info. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does flexible path prefix mean?

On Mon, Sep 29, 2014 at 10:09 AM, Dawn Chen notifications@github.com
wrote:

In pkg/api/ref.go:

+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package api
+
+import (

  • "fmt"
  • "regexp"
  • "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
    +)

+var versionFromSelfLink = regexp.MustCompile("/api/([^/]*)/")

Good catch! Let me file an issue to disallow flexible path prefixes or
have another way to retrieve version info. Thanks.

Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/1475/files#r18167889
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can start the apiserver today under any arbitrary path (http://foo.com/kubernetes/api).

On Sep 29, 2014, at 5:56 PM, Tim Hockin notifications@github.com wrote:

In pkg/api/ref.go:

+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package api
+
+import (

  • "fmt"
  • "regexp"
  • "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
    +)

+var versionFromSelfLink = regexp.MustCompile("/api/([^/]*)/")
What does flexible path prefix mean?


Reply to this email directly or view it on GitHub.


// GetReference returns an ObjectReference which refers to the given
// object, or an error if the object doesn't follow the conventions
// that would allow this.
func GetReference(obj runtime.Object) (*ObjectReference, error) {
jsonBase, err := runtime.FindJSONBase(obj)
if err != nil {
return nil, err
}
_, kind, err := Scheme.ObjectVersionAndKind(obj)
if err != nil {
return nil, err
}
version := versionFromSelfLink.FindStringSubmatch(jsonBase.SelfLink())
if len(version) < 2 {
return nil, fmt.Errorf("unexpected self link format: %v", jsonBase.SelfLink())
}
return &ObjectReference{
Kind: kind,
APIVersion: version[1],
// TODO: correct Name and UID when JSONBase makes a distinction
Name: jsonBase.ID(),
UID: jsonBase.ID(),
ResourceVersion: jsonBase.ResourceVersion(),
}, nil
}
95 changes: 95 additions & 0 deletions pkg/api/ref_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
Copyright 2014 Google Inc. All rights reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package api

import (
"reflect"
"testing"

"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
)

type FakeAPIObject struct{}

func (*FakeAPIObject) IsAnAPIObject() {}

func TestGetReference(t *testing.T) {
table := map[string]struct {
obj runtime.Object
ref *ObjectReference
shouldErr bool
}{
"pod": {
obj: &Pod{
JSONBase: JSONBase{
ID: "foo",
ResourceVersion: 42,
SelfLink: "/api/v1beta1/pods/foo",
},
},
ref: &ObjectReference{
Kind: "Pod",
APIVersion: "v1beta1",
Name: "foo",
UID: "foo",
ResourceVersion: 42,
},
},
"serviceList": {
obj: &ServiceList{
JSONBase: JSONBase{
ID: "foo",
ResourceVersion: 42,
SelfLink: "/api/v1beta2/services",
},
},
ref: &ObjectReference{
Kind: "ServiceList",
APIVersion: "v1beta2",
Name: "foo",
UID: "foo",
ResourceVersion: 42,
},
},
"badSelfLink": {
obj: &ServiceList{
JSONBase: JSONBase{
ID: "foo",
ResourceVersion: 42,
SelfLink: "v1beta2/services",
},
},
shouldErr: true,
},
"error": {
obj: &FakeAPIObject{},
ref: nil,
shouldErr: true,
},
}

for name, item := range table {
ref, err := GetReference(item.obj)
if e, a := item.shouldErr, (err != nil); e != a {
t.Errorf("%v: expected %v, got %v", name, e, a)
continue
}
if e, a := item.ref, ref; !reflect.DeepEqual(e, a) {
t.Errorf("%v: expected %#v, got %#v", name, e, a)
}
}
}
7 changes: 7 additions & 0 deletions pkg/runtime/scheme.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,17 @@ func (s *Scheme) AddKnownTypeWithName(version, kind string, obj Object) {
s.raw.AddKnownTypeWithName(version, kind, obj)
}

// KnownTypes returns the types known for the given version.
// Return value must be treated as read-only.
func (s *Scheme) KnownTypes(version string) map[string]reflect.Type {
return s.raw.KnownTypes(version)
}

// ObjectVersionAndKind returns the version and kind of the given Object.
func (s *Scheme) ObjectVersionAndKind(obj Object) (version, kind string, err error) {
return s.raw.ObjectVersionAndKind(obj)
}

// New returns a new API object of the given version ("" for internal
// representation) and name, or an error if it hasn't been registered.
func (s *Scheme) New(versionName, typeName string) (Object, error) {
Expand Down