New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubectl explain #15808
Fix kubectl explain #15808
Conversation
Labelling this PR as size/L |
GCE e2e test build/test passed for commit fe40a7a87cc332d125a2ca73a87fc80e6cc80612. |
This is not using a significant chunk of our generic rest client helper, which means it won't benefit from the standard work we do there. This needs to at minimum use a RESTClient and a request.go to fetch the provided resources, instead of performing http.client calls directly. |
@smarterclayton I copy-pasted your comment to #15659 |
fe40a7a
to
6f0f87b
Compare
Labelling this PR as size/M |
GCE e2e build/test failed for commit 6f0f87b. |
e2e is a flake:
|
@k8s-bot test this please |
GCE e2e test build/test passed for commit 6f0f87b. |
Ref #15874. If we're replacing
|
Hpa.extensions.spec should probably be type/fieldpath On Oct 19, 2015, at 6:39 PM, Janet Kuo notifications@github.com wrote: Ref #15874 #15874. If we're kubectl explain extensions/hpa.spec becomes kubectl explain — |
@janetkuo can we refactor the expected format of the input in another PR? I need this PR to unblock some other work. Thank you. |
Sure. |
Yes we can On Tue, Oct 20, 2015 at 2:02 PM, Chao Xu notifications@github.com wrote:
|
Please add some tests in the other PR too. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test failed for commit 6f0f87b. |
@k8s-bot test this please |
GCE e2e test build/test passed for commit 6f0f87b. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e test build/test passed for commit 6f0f87b. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
fix #15235
part of #15511
The first commit is #15659. Please only review the second commit.
With this PR,
kubectl explain
will accept resources in the extensions group, user can either callkubectl explain extensions/hpa
orkubectl explain hpa
.Caveats: --api-version is not working properly with non-v1 groupVersion. This is a problem for all kubectl commands, so I don't plan to address it in this PR.
@kubernetes/goog-ux @lavalamp