Add event creation library and implement in scheduler. #1789
Conversation
| @@ -73,6 +73,14 @@ type EndpointsInterface interface { | |||
| WatchEndpoints(ctx api.Context, label, field labels.Selector, resourceVersion string) (watch.Interface, error) | |||
| } | |||
|
|
|||
| // EventInterface has methods to work with Event resources | |||
There was a problem hiding this comment.
Need to pass context to these like the other method. I know you take issue with use of context in client, and I think your position is valid. But consistency please while we sort out that separate debate.
|
Note to self. Don't merge this until #1564 is merged and then after namespace changes added to client.go and perhaps elsewhere. |
|
Am I right that there is no timestamp in an Event other than the object creation timestamp? Probably there was some discussion about why this is a good thing, though I cannot fathom why. Could you point me at that discussion? |
| // StartReporting starts sending events to recorder. Call once while initializing | ||
| // your binary. Subsequent calls will be ignored. The return value can be ignored | ||
| // or used to stop reporting, if desired. | ||
| func StartReporting(recorder EventRecorder, sourceName string) watch.Interface { |
There was a problem hiding this comment.
(copied from comment in your fork)
Are 'report' and 'record' being used as synonyms? If so, pick one. If not, explain the distinction.
|
do kubecfg man pages need to be updated? |
|
Agree that events need a local timestamp in addition to the one they'll get on arrival at master, I realized that at some point but haven't fixed yet. I'll file an issue for that. |
|
Hm, can't find man pages for kubecfg? Looks like that got left out? |
|
OK, I think the only outstanding issue is what to do with contexts & namespaces. I would like to commit this as-is, and then wire namespaces up in a separate PR after @derekwaynecarr's PR gets merged. |
|
Please add the context in another PR soon. |
Add event creation library and implement in scheduler.
No description provided.