-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pod update e2e test in go. Also adjust validation logic a little. #1794
Conversation
…it more reasonable. Not integrated into existing e2e yet.
Is the idea that the e2e tests will drive this? |
Yeah, once this is, I'll add a script to the e2e suite to drive this binary. (and eventually we'll tear down the e2e scripts in favor of this binary.) |
I think--since you're starting a test framework here--that many of these functions should be put in a library. Is the plan one binary per e2e test, or all e2e tests in one binary? |
All tests in one library. I can split it out into a library, if you really On Tue, Oct 14, 2014 at 10:07 PM, Daniel Smith notifications@github.com
|
Don't have to do it for this change, but soon. Yes, we will have to unit test the test framework. Also, need a system where each e2e test goes in its own file or something, this is already too long for a single file IMO. Would be cool if it could be set up like the set of integration tests that @smarterclayton started. |
Ok, works for me, will take as a TODO. Can we merge this and then iterate? Thanks! |
Sure, we can iterate. |
Add a pod update e2e test in go. Also adjust validation logic a little.
OCPBUGS-23073: .spec.numberOfUsersToReport is not correctly applied in some circumstances
Not integrated into existing e2e yet.