Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pod update e2e test in go. Also adjust validation logic a little. #1794

Merged
merged 1 commit into from
Oct 15, 2014

Conversation

brendandburns
Copy link
Contributor

Not integrated into existing e2e yet.

…it more reasonable.

Not integrated into existing e2e yet.
@lavalamp
Copy link
Member

Is the idea that the e2e tests will drive this?

@brendandburns
Copy link
Contributor Author

Yeah, once this is, I'll add a script to the e2e suite to drive this binary.

(and eventually we'll tear down the e2e scripts in favor of this binary.)

@lavalamp
Copy link
Member

I think--since you're starting a test framework here--that many of these functions should be put in a library. Is the plan one binary per e2e test, or all e2e tests in one binary?

@brendandburns
Copy link
Contributor Author

All tests in one library. I can split it out into a library, if you really
prefer, but why, are we going to unit test the integration test? (I mean
we could, but...)

On Tue, Oct 14, 2014 at 10:07 PM, Daniel Smith notifications@github.com
wrote:

I think--since you're starting a test framework here--that many of these
functions should be put in a library. Is the plan one binary per e2e test,
or all e2e tests in one binary?


Reply to this email directly or view it on GitHub
#1794 (comment)
.

@lavalamp
Copy link
Member

Don't have to do it for this change, but soon. Yes, we will have to unit test the test framework.

Also, need a system where each e2e test goes in its own file or something, this is already too long for a single file IMO. Would be cool if it could be set up like the set of integration tests that @smarterclayton started.

@brendandburns
Copy link
Contributor Author

Ok, works for me, will take as a TODO. Can we merge this and then iterate?

Thanks!
--brendan

@lavalamp
Copy link
Member

Sure, we can iterate.

lavalamp added a commit that referenced this pull request Oct 15, 2014
Add a pod update e2e test in go. Also adjust validation logic a little.
@lavalamp lavalamp merged commit 2987747 into kubernetes:master Oct 15, 2014
sairameshv pushed a commit to sairameshv/kubernetes that referenced this pull request Nov 30, 2023
OCPBUGS-23073: .spec.numberOfUsersToReport is not correctly applied in some circumstances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants