Automated cherry pick of #15621 - initial empty SET PodUpdate #17947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
sttts
changed the title
sttts
changed the title
|
@k8s-bot unit test this |
|
GCE e2e test build/test passed for commit 6269f12. |
|
@smarterclayton it's not a flake. Looking into it. |
sttts
force-pushed
the
automated-cherry-pick-of-#15621-upstream-release-1.1
branch
from
6269f12
to
9e1e11f
Compare
|
GCE e2e build/test failed for commit 9e1e11fad7bf8b2809e23b77026422aa32fc32d5. |
|
@k8s-bot test this |
sttts
changed the title
|
GCE e2e test build/test passed for commit 9e1e11fad7bf8b2809e23b77026422aa32fc32d5. |
In PodConfigNotificationIncremental PodConfig mode, when no pods are available for a source, the Merge function correctly concluded that neither ADD, UPDATE nor REMOVE updates are to be sent to the kubelet. But as a consequence the kubelet will not mark that source as seen. This is usually not a problem for the apiserver source. But it is a problem for an empty "file" source, e.g. by passing an empty directory to the kubelet for static pods. Then the file source will never be seen and the kubelet will stay in its special not-all-source-seen mode.
sttts
force-pushed
the
automated-cherry-pick-of-#15621-upstream-release-1.1
branch
from
9e1e11f
to
560c830
Compare
|
Squashed and rebased, hopefully to a sane version without broken unit tests. |
|
GCE e2e test build/test passed for commit 560c830. |
|
@smarterclayton PTAL |
smarterclayton
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 560c830. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 2, 2015
…5621-upstream-release-1.1 Auto commit by PR queue bot
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…pick-of-#15621-upstream-release-1.1 Auto commit by PR queue bot
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…pick-of-#15621-upstream-release-1.1 Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #15621 on release-1.1.
This is part of a set of cherry-picks to fix Mesosphere e2e smoke tests for the release branch: mesosphere/kubernetes-mesos#640