Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #18718 #18759

Conversation

roberthbailey
Copy link
Contributor

Cherry pick of #18718 on release-1.1.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@roberthbailey
Copy link
Contributor Author

/cc @mikedanese

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2015
@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 16, 2015

GCE e2e build/test failed for commit 50f7702.

@roberthbailey
Copy link
Contributor Author

@k8s-bot unit test this
@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Dec 16, 2015

GCE e2e test build/test passed for commit 50f7702.

@roberthbailey
Copy link
Contributor Author

Setting cla flag to human approved since this is a straight cherry pick.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 17, 2015
…-#18718-upstream-release-1.1

Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 33506fc into kubernetes:release-1.1 Dec 17, 2015
@roberthbailey roberthbailey deleted the automated-cherry-pick-of-#18718-upstream-release-1.1 branch January 26, 2016 21:22
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ry-pick-of-#18718-upstream-release-1.1

Auto commit by PR queue bot
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…ry-pick-of-#18718-upstream-release-1.1

Auto commit by PR queue bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants