Specify Pod hostname by Annotation #20688

ArtfulCoder · 2016-02-05T02:26:59Z

Documentation: #22564

k8s-github-robot · 2016-02-05T02:36:19Z

Labelling this PR as size/L

k8s-bot · 2016-02-05T03:07:47Z

GCE e2e build/test failed for commit 7652cdbd96bec1a93f78518fc4d8b79c982196e7.

k8s-github-robot · 2016-02-05T12:57:38Z

PR needs rebase

k8s-bot · 2016-02-05T19:27:39Z

GCE e2e build/test failed for commit 55e46ff75921f1ea062f72189f8e253da7186a92.

k8s-bot · 2016-02-05T23:57:55Z

GCE e2e build/test failed for commit ff104a65646a632459c70a0200ef01f9203851c6.

k8s-bot · 2016-02-09T00:41:43Z

GCE e2e test build/test passed for commit 8b515bb514e22815aadcc9d0278845a8ad2574c8.

k8s-bot · 2016-02-09T17:20:31Z

GCE e2e test build/test passed for commit c4ea9b97d378a09857617f9d3a19972dcd75b651.

k8s-bot · 2016-02-09T21:59:36Z

GCE e2e build/test failed for commit 567c75d0f0a412ccaab43365f6c866d9a83b9e23.

thockin · 2016-02-09T22:42:29Z

cluster/addons/dns/kube2sky/kube2sky.go

@@ -62,7 +64,8 @@ const (
 	// A subdomain added to the user specified domain for all services.
 	serviceSubdomain = "svc"
 	// A subdomain added to the user specified dmoain for all pods.
-	podSubdomain = "pod"
+	podSubdomain           = "pod"
+	podHostNamesAnnotation = "net.beta.kubernetes.io/podHostnames"


should use the symbol from the shared pkg, no?

k8s-bot · 2016-02-09T22:53:22Z

GCE e2e build/test failed for commit 4f2a737e0c3f3310d974016760dba6b22278fdfb.

thockin · 2016-02-09T23:00:24Z

pkg/kubelet/dockertools/manager.go

@@ -507,6 +521,7 @@ func (dm *DockerManager) runContainer(
 			Env:          makeEnvList(opts.Envs),
 			ExposedPorts: exposedPorts,
 			Hostname:     containerHostname,
+			Domainname:   containerSubdomain,


did you figure out why it wasn't working when you showed me before?

we figured it out :)

derekwaynecarr · 2016-03-03T21:40:05Z

@thockin - yeah, @csrwng and I realized that after I posted it ;-)

thockin · 2016-03-03T21:42:54Z

That might be an interesting DNSPolicy option, but it's not one we have
now.

On Thu, Mar 3, 2016 at 1:40 PM, Derek Carr notifications@github.com wrote:

@thockin https://github.com/thockin - yeah, @csrwng
https://github.com/csrwng and I realized that after I posted it ;-)

—
Reply to this email directly or view it on GitHub
#20688 (comment)
.

derekwaynecarr · 2016-03-03T22:23:05Z

@thockin

https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/kube2sky/kube2sky.go#L92

https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/kube2sky/kube2sky.go#L230

Is the goal to get rid of the above (seems we watch pods already in dns)?

thockin · 2016-03-03T22:40:14Z

Yes, we will get rid of that when we do what you guys have already done
(use skyDNS backends)

On Thu, Mar 3, 2016 at 2:23 PM, Derek Carr notifications@github.com wrote:

@thockin https://github.com/thockin

https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/kube2sky/kube2sky.go#L92

https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/kube2sky/kube2sky.go#L230

Is the goal to get rid of the above (seems we watch pods already in dns)?

—
Reply to this email directly or view it on GitHub
#20688 (comment)
.

ArtfulCoder · 2016-03-04T16:24:08Z

PR pushed for review. Updating DNS doc in separate PR.

k8s-bot · 2016-03-04T16:55:26Z

GCE e2e build/test failed for commit 3d58ae29771911b4ca7fc79ef0f1da31093a137d.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

thockin · 2016-03-04T20:17:04Z

cluster/addons/dns/kube2sky/Makefile

@@ -18,8 +18,8 @@

 .PHONY: all kube2sky container push clean test

-TAG = 1.12
-PREFIX = gcr.io/google_containers
+TAG = 3.03.16-1


Push it and update the tags so we can merge? Need to merge with @bprashanth's changes

thockin · 2016-03-04T20:18:59Z

pkg/api/validation/validation.go

@@ -1875,6 +1900,7 @@ func ValidatePodTemplateSpec(spec *api.PodTemplateSpec, fldPath *field.Path) fie
 	allErrs := field.ErrorList{}
 	allErrs = append(allErrs, ValidateLabels(spec.Labels, fldPath.Child("labels"))...)
 	allErrs = append(allErrs, ValidateAnnotations(spec.Annotations, fldPath.Child("annotations"))...)
+	allErrs = append(allErrs, ValidatePodSpecificAnnotations(spec.Annotations, fldPath.Child("annotations"))...)


don't you need to call this from ValidatePod(), too ?

I had fixed this already. Can you take a look at the push I did 10 seconds
ago ?

On Fri, Mar 4, 2016 at 12:19 PM, Tim Hockin notifications@github.com
wrote:

In pkg/api/validation/validation.go
#20688 (comment)
:

@@ -1875,6 +1900,7 @@ func ValidatePodTemplateSpec(spec *api.PodTemplateSpec, fldPath *field.Path) fie
allErrs := field.ErrorList{}
allErrs = append(allErrs, ValidateLabels(spec.Labels, fldPath.Child("labels"))...)
allErrs = append(allErrs, ValidateAnnotations(spec.Annotations, fldPath.Child("annotations"))...)

allErrs = append(allErrs, ValidatePodSpecificAnnotations(spec.Annotations, fldPath.Child("annotations"))...)

don't you need to call this from ValidatePod(), too ?

—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/kubernetes/pull/20688/files#r55083329.

thockin · 2016-03-04T20:24:12Z

LGTM Just nits about the image push and tags

k8s-bot · 2016-03-04T20:52:44Z

GCE e2e build/test passed for commit 93673fe4d0e3ae8fda386b492d976c965e98b65d.

k8s-github-robot · 2016-03-04T20:52:55Z

@ArtfulCoder PR needs rebase

The hostname is a DNS A record, if the subdomain maps to a service name in the same namespace

ArtfulCoder · 2016-03-04T21:34:47Z

rebased, fixed image tag.

thockin · 2016-03-04T21:39:12Z

LGTM

k8s-bot · 2016-03-04T22:29:24Z

GCE e2e build/test passed for commit a3c00aa.

Specify Pod hostname by Annotation

Automatic merge from submit-queue Promote Pod Hostname & Subdomain to fields (were annotations) Deprecating the podHostName, subdomain and PodHostnames annotations and created corresponding new fields for them on PodSpec and Endpoints types. Annotation doc: #22564 Annotation code: #20688

googlebot added the cla: yes label Feb 5, 2016

k8s-github-robot assigned derekwaynecarr Feb 5, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2016

bgrant0607 mentioned this pull request Feb 5, 2016

Hostname shouldn't be set to the pod name #4825

Closed

ArtfulCoder force-pushed the podhostname branch from 7652cdb to 55e46ff Compare February 5, 2016 18:58

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2016

ArtfulCoder force-pushed the podhostname branch from 55e46ff to ff104a6 Compare February 5, 2016 23:27

ArtfulCoder force-pushed the podhostname branch from ff104a6 to 8b515bb Compare February 8, 2016 23:44

ArtfulCoder force-pushed the podhostname branch from 8b515bb to c4ea9b9 Compare February 9, 2016 16:52

ArtfulCoder force-pushed the podhostname branch from c4ea9b9 to 567c75d Compare February 9, 2016 21:17

k8s-github-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 9, 2016

ArtfulCoder force-pushed the podhostname branch from 567c75d to 4f2a737 Compare February 9, 2016 22:08

thockin reviewed Feb 9, 2016
View reviewed changes

thockin reviewed Mar 4, 2016
View reviewed changes

ArtfulCoder force-pushed the podhostname branch from 3d58ae2 to 93673fe Compare March 4, 2016 20:18

thockin reviewed Mar 4, 2016
View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2016

Specify hostname, subdomain via annotation on podspec.

a3c00aa

The hostname is a DNS A record, if the subdomain maps to a service name in the same namespace

ArtfulCoder force-pushed the podhostname branch from 93673fe to a3c00aa Compare March 4, 2016 21:32

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2016

thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2016

ArtfulCoder added a commit that referenced this pull request Mar 4, 2016

Merge pull request #20688 from ArtfulCoder/podhostname

9bfd70f

Specify Pod hostname by Annotation

ArtfulCoder merged commit 9bfd70f into kubernetes:master Mar 4, 2016

bgrant0607 added the cherrypick-candidate label Mar 8, 2016

eparis removed the cherrypick-candidate label Mar 9, 2016

liggitt mentioned this pull request Mar 21, 2016

Update skydns backend to use pod/endpoint hostname annotations openshift/origin#8179

Closed

bgrant0607 mentioned this pull request Mar 30, 2016

Proposal for implementing nominal services AKA StatefulSets AKA The-Proposal-Formerly-Known-As-PetSets #18016

Merged

ArtfulCoder mentioned this pull request Apr 15, 2016

Promote Pod Hostname & Subdomain to fields (were annotations) #24362

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specify Pod hostname by Annotation #20688

Specify Pod hostname by Annotation #20688

ArtfulCoder commented Feb 5, 2016

k8s-github-robot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-github-robot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-bot commented Feb 9, 2016

k8s-bot commented Feb 9, 2016

k8s-bot commented Feb 9, 2016

thockin Feb 9, 2016

ArtfulCoder Feb 11, 2016

k8s-bot commented Feb 9, 2016

thockin Feb 9, 2016

ArtfulCoder Feb 11, 2016

derekwaynecarr commented Mar 3, 2016

thockin commented Mar 3, 2016

derekwaynecarr commented Mar 3, 2016

thockin commented Mar 3, 2016

ArtfulCoder commented Mar 4, 2016

k8s-bot commented Mar 4, 2016

thockin Mar 4, 2016

thockin Mar 4, 2016

ArtfulCoder Mar 4, 2016

thockin Mar 4, 2016

thockin commented Mar 4, 2016

k8s-bot commented Mar 4, 2016

k8s-github-robot commented Mar 4, 2016

ArtfulCoder commented Mar 4, 2016

thockin commented Mar 4, 2016

k8s-bot commented Mar 4, 2016

Specify Pod hostname by Annotation #20688

Specify Pod hostname by Annotation #20688

Conversation

ArtfulCoder commented Feb 5, 2016

k8s-github-robot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-github-robot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-bot commented Feb 5, 2016

k8s-bot commented Feb 9, 2016

k8s-bot commented Feb 9, 2016

k8s-bot commented Feb 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-bot commented Feb 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr commented Mar 3, 2016

thockin commented Mar 3, 2016

derekwaynecarr commented Mar 3, 2016

thockin commented Mar 3, 2016

ArtfulCoder commented Mar 4, 2016

k8s-bot commented Mar 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thockin commented Mar 4, 2016

k8s-bot commented Mar 4, 2016

k8s-github-robot commented Mar 4, 2016

ArtfulCoder commented Mar 4, 2016

thockin commented Mar 4, 2016

k8s-bot commented Mar 4, 2016