Restart network container when container's configure is changed. #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -588,6 +588,14 @@ func (kl *Kubelet) syncPod(pod *api.BoundPod, dockerContainers dockertools.Docke | |||
| continue | |||
| } | |||
| killedContainers[containerID] = empty{} | |||
|
|
|||
| // Also kill associated network container | |||
There was a problem hiding this comment.
Won't this kill the network container multiple times?
There was a problem hiding this comment.
Yeah when there are several containers in a pod, and more than one container with new configurations. If only one has changed, we only kill it once. I could optimize that like what I mentioned in pr description but thought not necessary since we plan to replace network container soon.
|
LGTM, merging. |
brendandburns
added a commit
that referenced
this pull request
Nov 5, 2014
Restart network container when container's configure is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2099
I could improve this by figuring out if the network related configuration is changed, then decided if restart network container or not. But thought the user expects a blackout time during configuration update anyway.