Capture application termination messages/output #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -269,6 +269,9 @@ func validateContainers(containers []api.Container, volumes util.StringSet) errs | |||
| } | |||
| cErrs = append(cErrs, validatePorts(ctr.Ports).Prefix("ports")...) | |||
| cErrs = append(cErrs, validateEnv(ctr.Env).Prefix("env")...) | |||
| if len(ctr.TerminationMessagePath) == 0 { | |||
| ctr.TerminationMessagePath = "/dev/termination-log" | |||
There was a problem hiding this comment.
hmm, this has nothing to do with our RESTful API. This is docker container creator / users to indicate where the application should dump its final log inside container mount namespace.
dchen1107
force-pushed
the
deathrattle
branch
from
445141a
to
f9a90b9
Compare
|
Addressed all comments, especially moving default setting of terminationMessagePath from validation.go to conversion code. Like what we discussed offline, this PR support most of cases, but not support symbolic link, like glog case. Will file a separate issue to kubernetes or docker to handle that case. |
| for i := range out.Containers { | ||
| ctr := &out.Containers[i] | ||
| if len(ctr.TerminationMessagePath) == 0 { | ||
| ctr.TerminationMessagePath = "/dev/termination-log" |
There was a problem hiding this comment.
Make this a constant somewhere
…code to assign the default path. Move default setting for terminationMessagePath to conversion from validation. Addressed other comments.
the message to the upper layer through ContainerStatus.
dchen1107
force-pushed
the
deathrattle
branch
from
3877bbd
to
57454cc
Compare
|
Add TODO, squash the commits into 3 logic commits. |
|
Thanks. Will merge when green. |
bgrant0607
added a commit
that referenced
this pull request
Nov 10, 2014
Capture application termination messages/output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #139
Next PR is cleaning up the host file created for dead containers which should be garbage collected.