Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes/kubernetes#22625 Fix issue of out-of-date Terminating status #22626

Merged
merged 1 commit into from Mar 7, 2016
Merged

kubernetes/kubernetes#22625 Fix issue of out-of-date Terminating status #22626

merged 1 commit into from Mar 7, 2016

Conversation

xinxiaogang
Copy link
Contributor

  • During kubelet syncPod, check mirror pod DeletionTimestamp value to determine whether re-create mirror pod for running static pod.

Fixed #22625

@xinxiaogang
kubernetes#22625 Fix issue of out-of-date Terminating mirror pod st…
e2eccdd 
…atus

- During `kubelet` `syncPod`, check mirror pod `DeletionTimestamp` value to determine whether re-create mirror pod for running static pod.
@k8s-bot
Copy link

k8s-bot commented Mar 7, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Mar 7, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Mar 7, 2016

Can one of the admins verify that this patch is reasonable to test in $JOB_NAME? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2016
@xinxiaogang xinxiaogang mentioned this pull request Mar 7, 2016
Closed
@yujuhong yujuhong assigned Random-Liu and unassigned dchen1107 Mar 7, 2016
@Random-Liu
Copy link
Member

@k8s-bot ok to test.

@dchen1107
Copy link
Member

LGTM thanks for pr. Could you mind to send us a cherrypick pr to 1.2 branch too? thanks!

@dchen1107 dchen1107 added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Mar 7, 2016
@dchen1107 dchen1107 added this to the v1.2 milestone Mar 7, 2016
@dchen1107 dchen1107 added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 7, 2016
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@Random-Liu
Copy link
Member

@xinxiaogang LGTM, thanks!
@dchen1107 Thanks for your help. :)

@k8s-bot
Copy link

k8s-bot commented Mar 7, 2016

GCE e2e build/test passed for commit e2eccdd.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 7, 2016

GCE e2e build/test passed for commit e2eccdd.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 7, 2016
Merge pull request #22626 from xinxiaogang/xnxin-master
0e861a8 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 0e861a8 into kubernetes:master Mar 7, 2016
@dchen1107 dchen1107 mentioned this pull request Mar 8, 2016
Closed
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Apr 23, 2019
@k8s-publishing-bot
Merge pull request kubernetes#22626 from gnufied/skip-default-sc-tests
7800187 
UPSTREAM: 76625: Skip tests that depend on default SC

Origin-commit: b93a8e6b4ca785fa842383f93d57fb667ddbdee3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Random-Liu Random-Liu

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xinxiaogang @k8s-bot @k8s-github-robot @Random-Liu @dchen1107 @googlebot @eparis