Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet event on restart. #2267

Merged
merged 1 commit into from
Nov 10, 2014
Merged

Kubelet event on restart. #2267

merged 1 commit into from
Nov 10, 2014

Conversation

erictune
Copy link
Member

No description provided.

@lavalamp
Copy link
Member

You've got an extra commit in there; rebase?

@erictune
Copy link
Member Author

TBD whether we want to do this in other components, e.g. scheduler.
Kubelet local logging seems to make sense in addition to API logging (another PR) since it could be used in a config without a master to send events too, and since people may expect to find relevant logs locally when debugging.

lavalamp
lavalamp reviewed Nov 10, 2014
View reviewed changes
pkg/kubelet/kubelet.go
Name: kl.hostname,
UID: kl.hostname,
}
record.Eventf(ref, "", "starting", "Starting kubelet.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"running" for status (instead of "")? I didn't fill out a status for the container events you probably saw, but that's because a container is only a part of a pod. Here's it's probably safe to declare a status and not only a reason.

@erictune
Copy link
Member Author

Sorry, last comment was for another PR.

@lavalamp
Copy link
Member

LGTM; I don't see any problem with doing this for other components.

@erictune
Copy link
Member Author

Okay, but this PR is ready to go in as is.

lavalamp added a commit that referenced this pull request Nov 10, 2014
@lavalamp
Merge pull request #2267 from erictune/kubelet_events
b6f6898 
Kubelet event on restart.
@lavalamp lavalamp merged commit b6f6898 into kubernetes:master Nov 10, 2014
@erictune erictune deleted the kubelet_events branch November 10, 2014 23:04
@thockin thockin mentioned this pull request Apr 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictune @lavalamp