Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(github.com/docker/spdystream): 449fdfce4d962303d702fec724ef0ad181c92528 #22804

Merged
merged 1 commit into from
Mar 11, 2016
Merged

bump(github.com/docker/spdystream): 449fdfce4d962303d702fec724ef0ad181c92528 #22804

merged 1 commit into from
Mar 11, 2016

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Mar 10, 2016

Ref #19014

@ncdc ncdc added this to the v1.2 milestone Mar 10, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 10, 2016

GCE e2e build/test passed for commit 36243b8.

@ncdc ncdc mentioned this pull request Mar 10, 2016
Merged
@ncdc
Copy link
Member Author

ncdc commented Mar 10, 2016

cc @yujuhong FYI this, along with #22802 should hopefully resolve the goroutine leaks related to spdystream in #19014

@ncdc
Copy link
Member Author

ncdc commented Mar 10, 2016

@liggitt care to review?

@ncdc
Copy link
Member Author

ncdc commented Mar 10, 2016

cc @kubernetes/rh-cluster-infra

@lavalamp
Copy link
Member

LGTM, is there a test for this behavior in the dependency?

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2016
@ncdc
Copy link
Member Author

ncdc commented Mar 11, 2016

Yes, there is a test - see the most recent merged pull there.

On Thursday, March 10, 2016, Daniel Smith notifications@github.com wrote:

LGTM, is there a test for this behavior in the dependency?

—
Reply to this email directly or view it on GitHub
#22804 (comment)
.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 36243b8.

@ixdy
Copy link
Member

ixdy commented Mar 11, 2016

@k8s-bot unit test this please, issue #22834

@ixdy
Copy link
Member

ixdy commented Mar 11, 2016

@k8s-bot unit test this, issue #22843

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 36243b8.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 11, 2016
Merge pull request #22804 from ncdc/bump-spdystream
5e50302 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 5e50302 into kubernetes:master Mar 11, 2016
@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
@bgrant0607 bgrant0607 mentioned this pull request Mar 11, 2016
Merged
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
@eparis
Merge pull request kubernetes#22804 from ncdc/bump-spdystream
639dc1f 
Auto commit by PR queue bot
@ncdc ncdc mentioned this pull request Mar 11, 2016
Closed
85 tasks
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR was sucessfully cherry picked in PR #22855
please verify that the release-1.2 branch contains these changes as you would expect and contact @eparis if there appear to be problems.

@eparis eparis removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@eparis
Merge pull request kubernetes#22804 from ncdc/bump-spdystream
b488ceb 
Auto commit by PR queue bot
@ncdc ncdc deleted the bump-spdystream branch February 13, 2017 17:24
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@eparis
Merge pull request kubernetes#22804 from ncdc/bump-spdystream
a6148b9 
Auto commit by PR queue bot
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Aug 8, 2019
@k8s-publishing-bot
Merge pull request kubernetes#22804 from jcpowermac/cp-21398
bd9c8f1 
[release-3.11] UPSTREAM: 69313: kubelet: fix cri-o when using unix prefix

Origin-commit: 2b20ad0333138b7c70abcb7be6e91a37f2f20e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ncdc @k8s-github-robot @k8s-bot @lavalamp @ixdy @eparis @k8s-teamcity-mesosphere @googlebot @bgrant0607