-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jq to the kubekins-test image and pass through KUBE_FORCE_VERIFY_CHECKS #22834
Conversation
Travis is still gonna be busted... not sure if we want to fix that. |
Labelling this PR as size/XS |
(If we're happy with this change I'll push the image and re-run unit/integration tests.) |
LGTM |
GCE e2e build/test passed for commit 85bc91c. |
If you are happy, merge it. LGTM |
Self-merging so godep-changing PRs can work again. Will watch to make sure post-commit Jenkins doesn't fall over. |
Add jq to the kubekins-test image and pass through KUBE_FORCE_VERIFY_CHECKS
Now this is failing differently, and I don't understand why; it works fine locally.
|
@ixdy Can we revert? submit queue is blocked. |
@bgrant0607 how about #22844, which just disables this check? |
Fixes after #22681.
Note that I haven't pushed kubekins-test:0.8 yet, so this will fail (and shouldn't be merged).
cc @eparis @kubernetes/sig-testing