image operation conformance test #22933

liangchenye · 2016-03-14T10:25:41Z

The image operation is separated from runtime operation but they are sharing the same conform_test.
Works in my GCE.

Signed-off-by: liang chenye liangchenye@huawei.com

k8s-github-robot · 2016-03-14T10:29:03Z

Labelling this PR as size/L

k8s-bot · 2016-03-14T11:10:40Z

GCE e2e build/test failed for commit afc42d57dc723d2aada1f1168e71fbcb6871056a.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

liangchenye · 2016-03-15T07:23:34Z

Same error with #20916
NODE_NAMES=e2e-gce-master-0-minion-4daq e2e-gce-master-0-minion-5nve e2e-gce-master-0-minion-8lyx e2e-gce-master-0-minion-i5eg e2e-gce-master-0-minion-k9cb e2e-gce-master-0-minion-nxd2
Using master: e2e-gce-master-0-master (external IP: 104.154.16.30)
Waiting up to 300 seconds for cluster initialization.

This will continually check to see if the API for kubernetes is reachable.
This may time out if there was some uncaught error during start up.

k8s-bot · 2016-03-15T07:30:21Z

GCE e2e build/test passed for commit a133ed529b283d766dee0e92698f86cc416c80e5.

k8s-github-robot · 2016-03-15T07:34:41Z

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

k8s-bot · 2016-03-15T07:36:57Z

GCE e2e build/test failed for commit a133ed529b283d766dee0e92698f86cc416c80e5.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

liangchenye · 2016-03-15T09:23:51Z

@k8s-bot e2e test this, issue: #20916

k8s-bot · 2016-03-15T09:31:18Z

GCE e2e build/test passed for commit e15dbd64a9c954f47f9670ff74df608eed9a4ae9.

k8s-bot · 2016-03-15T09:31:38Z

GCE e2e build/test passed for commit e15dbd64a9c954f47f9670ff74df608eed9a4ae9.

k8s-bot · 2016-03-15T09:52:02Z

GCE e2e build/test passed for commit b20dd160d5149ed94e565fb346c68687e3158362.

k8s-bot · 2016-03-15T09:53:51Z

GCE e2e build/test passed for commit b20dd160d5149ed94e565fb346c68687e3158362.

liangchenye · 2016-03-15T10:17:37Z

@Random-Liu @pwittrock
add image pull/remove, works in my test.

Random-Liu · 2016-03-15T20:16:56Z

Also /cc @dchen1107 @kubernetes/sig-node

Random-Liu · 2016-03-15T22:35:51Z

test/e2e_node/image.go

+	}
+
+	return nil
+}


@liangchenye It seems that there is no test for ListImages(), :)

I'm not sure which images are persistent on gci.io/google_containers and suitable for testing.
I'll use images which are referenced in other testing code in k8s.

k8s-bot · 2016-03-16T11:58:05Z

GCE e2e build/test failed for commit e6fda0a992b8eab728cd6381b7bb8b4d34ae4394.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-16T12:11:52Z

GCE e2e build/test failed for commit 68fd470aceb485025ce5cc8d726cd713e308e0d0.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-16T12:20:05Z

GCE e2e build/test failed for commit ba2cea466b3b5196066ef45d119bcf096be55a18.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

liangchenye · 2016-03-16T12:33:02Z

@k8s-bot e2e test this, issue: #20916

k8s-bot · 2016-03-16T13:05:18Z

GCE e2e build/test passed for commit 0da8d45e605f0aa23b64fa4a2f1f00e9d33b649b.

k8s-bot · 2016-03-16T13:06:21Z

GCE e2e build/test passed for commit 0da8d45e605f0aa23b64fa4a2f1f00e9d33b649b.

liangchenye · 2016-03-16T13:48:04Z

@k8s-bot e2e test this, issue: #20916

liangchenye · 2016-03-16T13:58:23Z

update: remove useless 'error' after GarbageCollect; add imageList

k8s-bot · 2016-03-16T14:16:42Z

GCE e2e build/test passed for commit 5d84126993d84dc0eb22fd4ebcd6b8a3d8e53415.

liangchenye · 2016-03-17T07:27:53Z

@k8s-bot e2e test this, issue: #20916

liangchenye · 2016-03-17T07:29:03Z

update:

change code style
add TODO to remind 'not to expose implement details once the container API refactored'

k8s-bot · 2016-03-17T07:29:43Z

GCE e2e build/test failed for commit bfb4b56ea6342003ca96a817785c09a89b338e4f.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-17T07:30:51Z

GCE e2e build/test failed for commit 182961b13a3714d65f29f8c92bf4d9e2672fcb3f.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-17T07:57:01Z

GCE e2e build/test passed for commit 41d4082.

pwittrock · 2016-03-17T15:37:38Z

Send a PTAL when ready for rereview

pwittrock · 2016-03-17T15:37:51Z

@k8s-bot test node e2e experimental

pwittrock · 2016-03-17T22:39:55Z

@k8s-bot test node e2e experimental

pwittrock · 2016-03-17T23:13:24Z

tests look to be failing

Summarizing 3 Failures:

[Fail] Container Conformance Test container conformance blackbox test when testing images that exist [It] it should pull successfully [Conformance] 
/var/lib/jenkins/workspace/node-pull-build-e2e-test/go/src/k8s.io/kubernetes/test/e2e_node/conformance_test.go:58

[Fail] Container Conformance Test container conformance blackbox test when testing images that exist [It] it should list pulled images [Conformance] 
/var/lib/jenkins/workspace/node-pull-build-e2e-test/go/src/k8s.io/kubernetes/test/e2e_node/conformance_test.go:67

[Fail] Container Conformance Test container conformance blackbox test when testing images that exist [It] it should remove successfully [Conformance] 
/var/lib/jenkins/workspace/node-pull-build-e2e-test/go/src/k8s.io/kubernetes/test/e2e_node/conformance_test.go:73

Ran 19 of 19 Specs in 526.436 seconds
FAIL! -- 16 Passed | 3 Failed | 0 Pending | 0 Skipped --- FAIL: TestE2eNode (526.45s)
FAIL

liangchenye · 2016-03-18T09:22:21Z

From the log, the imageConform test which uses dockertool directly failed to connect to docker daemon on the testing machines. (dial unix /var/run/docker.sock: permission denied)
But it do works in my GCE. I guess there is something wrong when I use dockertool in image.go.

pwittrock · 2016-03-18T17:00:12Z

Ah, I bet the issue is that Jenkins isn't in the docker group on the test machines. I will need to update the images.

pwittrock · 2016-03-21T19:55:27Z

@k8s-bot test node e2e experimental

pwittrock · 2016-03-21T21:23:21Z

Looks good.

k8s-github-robot · 2016-03-21T21:32:59Z

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

k8s-bot · 2016-03-21T22:10:04Z

GCE e2e build/test passed for commit 41d4082.

k8s-github-robot · 2016-03-22T08:26:00Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-03-22T08:59:13Z

GCE e2e build/test passed for commit 41d4082.

k8s-github-robot · 2016-03-22T09:44:49Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-03-22T10:15:05Z

GCE e2e build/test passed for commit 41d4082.

k8s-github-robot · 2016-03-22T10:51:06Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-03-22T11:20:16Z

GCE e2e build/test passed for commit 41d4082.

k8s-github-robot · 2016-03-22T11:27:49Z

Automatic merge from submit-queue

Auto commit by PR queue bot

UPSTREAM: 76188: csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call Origin-commit: 876a109dbd63a4bd3158976180eae3ff407f0d99

googlebot added the cla: yes label Mar 14, 2016

k8s-github-robot assigned fejta Mar 14, 2016

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2016

k8s-github-robot added the needs-ok-to-merge label Mar 15, 2016

Random-Liu assigned pwittrock and unassigned fejta Mar 15, 2016

Random-Liu reviewed Mar 15, 2016
View reviewed changes

pwittrock added ok-to-merge lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 21, 2016

k8s-github-robot removed the needs-ok-to-merge label Mar 21, 2016

k8s-github-robot pushed a commit that referenced this pull request Mar 22, 2016

Merge pull request #22933 from liangchenye/imageConform

d37baf7

Auto commit by PR queue bot

k8s-github-robot merged commit d37baf7 into kubernetes:master Mar 22, 2016

bprashanth mentioned this pull request Apr 7, 2016

e2e Flake: Cluster failed to initialize within 300 seconds (possible metadata server issue?) #20916

Closed

aronchick mentioned this pull request Aug 25, 2016

Automate Docker Validation Process kubernetes/enhancements#57

Closed

16 tasks

image operation conformance test #22933

image operation conformance test #22933

Conversation

liangchenye commented Mar 14, 2016

k8s-github-robot commented Mar 14, 2016

k8s-bot commented Mar 14, 2016

liangchenye commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

k8s-github-robot commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

liangchenye commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

k8s-bot commented Mar 15, 2016

liangchenye commented Mar 15, 2016

Random-Liu commented Mar 15, 2016

Random-Liu Mar 15, 2016

Choose a reason for hiding this comment

liangchenye Mar 16, 2016

Choose a reason for hiding this comment

k8s-bot commented Mar 16, 2016

k8s-bot commented Mar 16, 2016

k8s-bot commented Mar 16, 2016

liangchenye commented Mar 16, 2016

k8s-bot commented Mar 16, 2016

k8s-bot commented Mar 16, 2016

liangchenye commented Mar 16, 2016

liangchenye commented Mar 16, 2016

k8s-bot commented Mar 16, 2016

liangchenye commented Mar 17, 2016

liangchenye commented Mar 17, 2016

k8s-bot commented Mar 17, 2016

k8s-bot commented Mar 17, 2016

k8s-bot commented Mar 17, 2016

pwittrock commented Mar 17, 2016

pwittrock commented Mar 17, 2016

pwittrock commented Mar 17, 2016

pwittrock commented Mar 17, 2016

liangchenye commented Mar 18, 2016

pwittrock commented Mar 18, 2016

pwittrock commented Mar 21, 2016

pwittrock commented Mar 21, 2016

k8s-github-robot commented Mar 21, 2016

k8s-bot commented Mar 21, 2016

k8s-github-robot commented Mar 22, 2016

k8s-bot commented Mar 22, 2016

k8s-github-robot commented Mar 22, 2016

k8s-bot commented Mar 22, 2016

k8s-github-robot commented Mar 22, 2016

k8s-bot commented Mar 22, 2016

k8s-github-robot commented Mar 22, 2016