Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure status is not changed during an update of PV, PVC, HPA objects #24924

Merged
merged 2 commits into from
May 5, 2016
Merged

Ensure status is not changed during an update of PV, PVC, HPA objects #24924

merged 2 commits into from
May 5, 2016

Conversation

mqliang
Copy link
Contributor

@mqliang mqliang commented Apr 28, 2016

No description provided.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 28, 2016
@smarterclayton smarterclayton added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 3, 2016
@smarterclayton
Copy link
Contributor

@liggitt FYI

@smarterclayton smarterclayton added this to the v1.2 milestone May 3, 2016
@roberthbailey
Copy link
Contributor

@smarterclayton - should we get this merged / cherry picked so that we can get it into the next release?

@smarterclayton
Copy link
Contributor

Yes

@smarterclayton
Copy link
Contributor

Looks like my comment from last night was lost in the mail - HPA also has this bug and needs to get updated.

@a-robinson
Copy link
Contributor

@mqliang - any chance of getting this PR updated to include HPA today/tonight? This is the only cherrypick candidate remaining for the next patch release that isn't ready to be merged.

@mqliang
Copy link
Contributor Author

mqliang commented May 5, 2016

@a-robinson @smarterclayton HPA included. PTAL.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2016
@a-robinson
Copy link
Contributor

Thanks @mqliang. LGTM, but I'll defer to @smarterclayton

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2016
@smarterclayton
Copy link
Contributor

Lgtm, thanks.

@roberthbailey roberthbailey added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 5, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 5, 2016

GCE e2e build/test passed for commit 0109c08.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3faf214 into kubernetes:master May 5, 2016
@mqliang mqliang deleted the pv-prepare-update branch May 5, 2016 09:02
@roberthbailey roberthbailey mentioned this pull request May 5, 2016
Merged
@roberthbailey
Copy link
Contributor

@smarterclayton Since we want to cherry pick this PR we should set a release note. Can you update the issue title?

@liggitt liggitt changed the title fix PrepareForUpdate bug for PV and PVC Ensure status is not changed during an update of PV, PVC, HPA objects May 5, 2016
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 5, 2016
@roberthbailey
Copy link
Contributor

Thanks @liggitt!

roberthbailey added a commit that referenced this pull request May 5, 2016
@roberthbailey
Merge pull request #25202 from roberthbailey/automated-cherry-pick-of…
eb6d458 
…-#24924-upstream-release-1.2

Automated cherry pick of #24924 upstream release 1.2
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@roberthbailey
Merge pull request kubernetes#25202 from roberthbailey/automated-cher…
7602219 
…ry-pick-of-#24924-upstream-release-1.2

Automated cherry pick of kubernetes#24924 upstream release 1.2
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@roberthbailey
Merge pull request kubernetes#25202 from roberthbailey/automated-cher…
82742c4 
…ry-pick-of-#24924-upstream-release-1.2

Automated cherry pick of kubernetes#24924 upstream release 1.2
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request May 14, 2020
@k8s-publishing-bot
Merge pull request kubernetes#24924 from p0lyn0mial/releae-4-4-tmp-fi…
2bec654 
…x-crd-publishing-tests

Bug 1828790: provides a temporal fix to improve CRD publishing e2e tests in an HA setup

Origin-commit: 19c011f7e9efb69c6dd0ac25c81fa64ab2aad92c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mqliang @smarterclayton @roberthbailey @a-robinson @k8s-github-robot @k8s-bot @k8s-cherrypick-bot @liggitt @googlebot