Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets IgnoreUnknown=1 in CNI_ARGS #24983

Merged
merged 1 commit into from Jun 11, 2016
Merged

Sets IgnoreUnknown=1 in CNI_ARGS #24983

merged 1 commit into from Jun 11, 2016

Conversation

Arvinderpal
Copy link
Contributor

@Arvinderpal Arvinderpal commented Apr 29, 2016 •
edited 

release-note-none

K8 uses CNI_ARGS to pass pod namespace, name and infra container
id to the CNI network plugin. CNI logic will throw an error
if these args are not known to it, unless the user specifies
IgnoreUnknown as part of CNI_ARGS. This PR sets IgnoreUnknown=1
to prevent the CNI logic from erroring and blocking pod setup.
containernetworking/cni#158
containernetworking/cni#126

@Arvinderpal
Sets IgnoreUnknown=1 in CNI_ARGS
dede4d5 
K8 uses CNI_ARGS to pass pod namespace, name and infra container
id to the CNI network plugin. CNI logic will throw an error
if these args are not known to it, unless the user specifies
IgnoreUnknown as part of CNI_ARGS. This PR sets IgnoreUnknown=1
to prevent the CNI logic from erroring and blocking pod setup.
containernetworking/cni#158
containernetworking/cni#126
@k8s-bot
Copy link

k8s-bot commented Apr 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Apr 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 29, 2016
@k8s-bot
Copy link

k8s-bot commented Apr 29, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@freehan freehan self-assigned this Jun 6, 2016
@freehan freehan mentioned this pull request Jun 6, 2016
Closed
@freehan freehan added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 6, 2016
@luxas
Copy link
Member

luxas commented Jun 6, 2016

@k8s-bot ok to test

@luxas luxas added this to the v1.3 milestone Jun 6, 2016
@luxas
Copy link
Member

luxas commented Jun 8, 2016

ok to test

@luxas
Copy link
Member

luxas commented Jun 8, 2016

ping @ixdy, the bot isn't very friendly right now :(

@luxas
Copy link
Member

luxas commented Jun 8, 2016

haha @ixdy super powers ftw 😄

doesn't "ok to test" work anymore?

@k8s-github-robot
Copy link

@ixdy
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-bot
Copy link

k8s-bot commented Jun 8, 2016

GCE e2e build/test passed for commit dede4d5.

@ixdy
Copy link
Member

ixdy commented Jun 8, 2016

@luxas it works, but only for those on the admin list - I think you're only on the whitelist.

@ixdy
Copy link
Member

ixdy commented Jun 8, 2016

(which is probably a mistake. unfortunately that list is maintained separately from the kubernetes github teams currently.)

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2016
@dchen1107
Copy link
Member

lgtm

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 11, 2016

GCE e2e build/test passed for commit dede4d5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 64da66b into kubernetes:master Jun 11, 2016
@luxas luxas mentioned this pull request Jun 12, 2016
Closed
@nikhiljindal nikhiljindal mentioned this pull request Jun 14, 2016
Merged
@rkamudhan
Copy link
Contributor

@Arvinderpal @luxas I am experiencing this issue in Kubernetes > 1.4.0 version. Tested with Kubernetes 1.3.6 version, it is working fine.

@tomdee tomdee mentioned this pull request Dec 7, 2016
Closed
@abhi abhi mentioned this pull request Mar 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@freehan freehan

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Arvinderpal @k8s-bot @luxas @k8s-github-robot @ixdy @dchen1107 @rkamudhan @freehan @googlebot