Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

federation: setting a default value for FEDERATION_NAME #27333

Merged
merged 1 commit into from Jun 14, 2016
Merged

federation: setting a default value for FEDERATION_NAME #27333

merged 1 commit into from Jun 14, 2016

Conversation

nikhiljindal
Copy link
Contributor

federation tests are failing right now on jenkins:

http://kubekins.dls.corp.google.com/view/Critical%20Builds/job/kubernetes-e2e-gce-federation/694/

FEDERATION_NAME environment variable must be set

Setting a default value to "federation"

cc @kubernetes/sig-cluster-federation @mml

@nikhiljindal nikhiljindal added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/cluster-federation and removed cla: yes labels Jun 14, 2016
@nikhiljindal nikhiljindal added this to the v1.3 milestone Jun 14, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 14, 2016
@nikhiljindal nikhiljindal added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 14, 2016
@nikhiljindal
Copy link
Contributor Author

Setting P0 since the e2e suite is failing right now

@nikhiljindal nikhiljindal added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed cla: yes priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 14, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 14, 2016

GCE e2e build/test passed for commit e0bdb32.

@nikhiljindal
Copy link
Contributor Author

nikhiljindal commented Jun 14, 2016 •
edited

(logs say all tests passed)
@k8s-bot node e2e test this issue: #IGNORE

@nikhiljindal nikhiljindal mentioned this pull request Jun 14, 2016
Merged
@nikhiljindal
Copy link
Contributor Author

(logs say all tests passed)
@k8s-bot node e2e test this issue: #IGNORE

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2016
@fejta
Copy link
Contributor

fejta commented Jun 14, 2016

@k8s-bot node e2e test this issue #24479

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6e5faf5 into kubernetes:master Jun 14, 2016
@nikhiljindal nikhiljindal mentioned this pull request Jun 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nikhiljindal @k8s-bot @fejta @k8s-github-robot @madhusudancs @googlebot @wojtek-t