-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add docker validation test #25471
Conversation
@liangchenye Nice! |
} | ||
|
||
func (cc *ConformanceContainer) Start() error { | ||
_, err := exec.Command("service", cc.Name, "start").CombinedOutput() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work on systemd node, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will add more checking codes to the 'start' function.
Signed-off-by: liang chenye <liangchenye@huawei.com>
@Random-Liu I add your @dchen1107 I update previous limitation code by supporting both 'init/systemd'. I'll remove the 'WIP' and ask for a review once the jenkins integration is done. |
Signed-off-by: liang chenye <liangchenye@huawei.com>
@Random-Liu I add 4 cases: start/start-in-parallel/list/list-in-parallel.
|
@k8s-bot test this issue #IGNORE. |
You need to run |
@liangchenye PR needs rebase |
GCE e2e build/test passed for commit e0a66fd. |
ping ... @liangchenye any updates on this pr? |
ping ... |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review. You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days |
The docker validation test including:
Since the docker unique testing affects other container test, for example, list/status.
I think we cannot test them simultaneously in docker validation test.
So I'll test 1~3 one by one.
[conformance test]
In current e2e-node test, we already have very solid code to setup k8s environment.
I think we can just reuse them, but will be more parameters (like test on a certain GCE?)
(
docker-validation-test.sh
is modifies from e2e-node-test.sh)[performance test]
I'm not sure how to integrate with @Random-Liu 's work .
[docker unique test]
I add a 'restart' testcase in this PR. It works good in my docker version..
@dchen1107 @Random-Liu
This change is