Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add docker validation test #25471

Closed
wants to merge 2 commits into from
Closed

WIP: add docker validation test #25471

wants to merge 2 commits into from

Conversation

liangchenye
Copy link
Contributor

@liangchenye liangchenye commented May 11, 2016

The docker validation test including:

  1. conformance test
  2. performance test
  3. docker unique test (restart docker on upgrade for example)
    Since the docker unique testing affects other container test, for example, list/status.
    I think we cannot test them simultaneously in docker validation test.
    So I'll test 1~3 one by one.

[conformance test]
In current e2e-node test, we already have very solid code to setup k8s environment.
I think we can just reuse them, but will be more parameters (like test on a certain GCE?)
(docker-validation-test.sh is modifies from e2e-node-test.sh)

[performance test]
I'm not sure how to integrate with @Random-Liu 's work .

[docker unique test]
I add a 'restart' testcase in this PR. It works good in my docker version..

@dchen1107 @Random-Liu


This change is Reviewable

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 11, 2016
@Random-Liu Random-Liu assigned Random-Liu and unassigned zmerlynn May 11, 2016
@Random-Liu
Copy link
Member

@liangchenye Nice!

@dchen1107 dchen1107 added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 11, 2016
}

func (cc *ConformanceContainer) Start() error {
_, err := exec.Command("service", cc.Name, "start").CombinedOutput()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on systemd node, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add more checking codes to the 'start' function.

Signed-off-by: liang chenye <liangchenye@huawei.com>
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2016
@liangchenye
Copy link
Contributor Author

@Random-Liu I add your helpers code and one of your case.
Just as we discussed today, I'll submit small case(code) first.

@dchen1107 I update previous limitation code by supporting both 'init/systemd'.
(get reference from https://github.com/autotest/autotest-docker/blob/master/dockertest/docker_daemon.py )

I'll remove the 'WIP' and ask for a review once the jenkins integration is done.

Signed-off-by: liang chenye <liangchenye@huawei.com>
@liangchenye
Copy link
Contributor Author

@Random-Liu I add 4 cases: start/start-in-parallel/list/list-in-parallel.
Each measurement has 10 containers and runs related operation twice.
The output is like this:

• [MEASUREMENT]
start:
  Fastest Time: 3.920s
  Slowest Time: 3.936s
  Average Time: 3.928s ± 0.008s

start parallelly:
  Fastest Time: 0.692s
  Slowest Time: 0.886s
  Average Time: 0.789s ± 0.097s

list:
  Fastest Time: 0.154s
  Slowest Time: 0.158s
  Average Time: 0.156s ± 0.002s

list parallelly:
  Fastest Time: 0.132s
  Slowest Time: 0.134s
  Average Time: 0.133s ± 0.001s

@Random-Liu
Copy link
Member

@k8s-bot test this issue #IGNORE.

@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 28, 2016
@Random-Liu
Copy link
Member

Random-Liu commented May 28, 2016

FAILED ./hack/../hack/verify-boilerplate.sh 1s

You need to run hack/verify-boilerplate.sh to verify boilerplate and add boilerplate accordingly.

@k8s-github-robot
Copy link

@liangchenye PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 21, 2016

GCE e2e build/test passed for commit e0a66fd.

@dchen1107
Copy link
Member

ping ...

@liangchenye any updates on this pr?

@dchen1107
Copy link
Member

ping ...

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot
Copy link

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @Random-Liu @liangchenye

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants