Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.7 #28742

Merged
merged 5 commits into from
Oct 18, 2016
Merged

Update to go 1.7 #28742

merged 5 commits into from
Oct 18, 2016

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jul 10, 2016 •
edited by pwittrock
Loading

Closes #33070
Closes #32999

Updated Go to 1.7

Analytics

This is to test go version 1.7

This change is Reviewable

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 10, 2016
@jessfraz jessfraz added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 10, 2016
@jessfraz
Copy link
Contributor Author

added the do-not-merge because this is just for testing and benchmarking for the time being

@bprashanth
Copy link
Contributor

you should try the scalability suite in a loop (#17524)

@jessfraz
Copy link
Contributor Author

Ah cool thanks will do!!!

On Sun, Jul 10, 2016 at 2:44 PM, Prashanth B notifications@github.com
wrote:

you should try the scalability suite in a loop (#17524
#17524)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#28742 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABYNbGPjinHfOJNSBTtuiOAafkFG2SVEks5qUWfPgaJpZM4JI5md
.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2016
@luxas
Copy link
Member

luxas commented Jul 11, 2016

Nice!
Please cc me on these upgrades, I've done some earlier, and am interested in this.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2016
@jessfraz jessfraz changed the title Update to go 1.7rc1 Update to go 1.7rc2 Jul 18, 2016
@k8s-github-robot
Copy link

@jfrazelle
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2016
@jessfraz jessfraz changed the title Update to go 1.7rc2 Update to go 1.7rc3 Jul 25, 2016
@jessfraz jessfraz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 25, 2016
@jessfraz jessfraz force-pushed the test-go1.7rc1 branch 2 times, most recently from 5d05803 to bbf4473 Compare July 25, 2016 21:46
@nhlfr nhlfr mentioned this pull request Oct 11, 2016
Closed
@luxas
Copy link
Member

luxas commented Oct 11, 2016

@k8s-bot gce e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit daeb85e19278c23491c8c70455205356e3e565f1. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@luxas
Copy link
Member

luxas commented Oct 11, 2016

@ixdy Seems like you ran out of firewalls quota for GCE e2e...

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2016
@jessfraz
Copy link
Contributor Author

its greeeeennnn

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2016
@luxas
Copy link
Member

luxas commented Oct 13, 2016

@lavalamp or @wojtek-t can you manually merge next time it's green or just add lgtm?
It already has P0, so it should merge before anything other.

Really want this now

jessfraz and others added 5 commits October 13, 2016 21:12
@jessfraz
Update to go1.7.1
3803fee 
Signed-off-by: Jess Frazelle <me@jessfraz.com>
@jessfraz
vet fixes
d51962e 
Signed-off-by: Jess Frazelle <me@jessfraz.com>
@jessfraz
Remove go patches for darwin
3193174 
Signed-off-by: Jess Frazelle <acidburn@google.com>
@jessfraz
fix unit test for TLS and linted packages
20db0ad 
Signed-off-by: Jess Frazelle <acidburn@google.com>
@jessfraz
update generated protobuf
db33b49 
Signed-off-by: Jess Frazelle <acidburn@google.com>
@jessfraz
Copy link
Contributor Author

rebased

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2016
@jessfraz
Copy link
Contributor Author

its green again!

@luxas
Copy link
Member

luxas commented Oct 17, 2016

@wojtek-t @lavalamp once again, friendly ping to merge this ASAP

@wojtek-t
Copy link
Member

sorry - let's try it

LGTM

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit db33b49. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6e2f5f8 into kubernetes:master Oct 18, 2016
@jessfraz jessfraz deleted the test-go1.7rc1 branch October 18, 2016 12:59
@ixdy
Copy link
Member

ixdy commented Oct 18, 2016

On Jenkins, looks like fastbuilds are about 5m faster, crossbuilds 10m faster.

@jessfraz
Copy link
Contributor Author

yayyyyy!

On Tue, Oct 18, 2016 at 11:25 AM, Jeff Grafton notifications@github.com
wrote:

On Jenkins, looks like fastbuilds are about 5m faster, crossbuilds 10m
faster.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28742 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbFHM5HdwH6L1YOBCHBqvQRkAeeQaks5q1Q81gaJpZM4JI5md
.

@andronat andronat mentioned this pull request Oct 26, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@krzyzacy krzyzacy krzyzacy left review comments

@wojtek-t wojtek-t wojtek-t left review comments

Assignees

@lavalamp lavalamp

@wojtek-t wojtek-t

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5