use a separate queue for initial quota calculation #29133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/M
| @@ -63,6 +63,8 @@ type ResourceQuotaController struct { | |||
| rqController *framework.Controller | |||
| // ResourceQuota objects that need to be synchronized | |||
| queue workqueue.RateLimitingInterface | |||
| // missingStatusQueue holds objects that are missing the initial usage informatino | |||
There was a problem hiding this comment.
nit: update godoc to reflect name (suspect you changed it at some point)
derekwaynecarr
added
release-note-none
|
comments addressed. |
|
LGTM |
derekwaynecarr
added
the
lgtm
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit 2ea3422. |
| @@ -63,6 +63,8 @@ type ResourceQuotaController struct { | |||
| rqController *framework.Controller | |||
| // ResourceQuota objects that need to be synchronized | |||
| queue workqueue.RateLimitingInterface | |||
| // missingUsageQueue holds objects that are missing the initial usage informatino | |||
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 2ea3422. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the quota controller gets backed up on resyncs, it can take a long time to observe the first usage stats which are needed by the admission plugin. This creates a second queue to prioritize the initial calculation.