Node Conformance Test: Statically link apiserver #30211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
added
area/test
sig/node
Random-Liu
added
the
release-note-none
10 tasks
k8s-github-robot
added
the
size/XL
k8s-github-robot
added
the
needs-rebase
Random-Liu
force-pushed
the
statically-link-apiserver
branch
from
3d2b0d5
to
62dcd13
Compare
k8s-github-robot
added
needs-rebase
Random-Liu
force-pushed
the
statically-link-apiserver
branch
from
62dcd13
to
4143dbc
Compare
k8s-github-robot
added
needs-rebase
|
This PR is not for the master branch but does not have the |
k8s-github-robot
added
do-not-merge
|
lgtm |
|
feel free to mark this PR lgtm once the dependencies are merged. |
|
@vishh Thanks~ :) |
Random-Liu
removed
the
do-not-merge
Random-Liu
force-pushed
the
statically-link-apiserver
branch
from
4143dbc
to
dd6584a
Compare
|
Just rebase, apply LGTM based on #30211 (comment) |
Random-Liu
added
the
lgtm
k8s-github-robot
added
size/L
|
GCE e2e build/test passed for commit dd6584a. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit dd6584a. |
|
Automatic merge from submit-queue |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #30122, #30174.
Based on #30116, #30198, #30200.
Please only review the 4th PR.
This PR is part of our roadmap to package node conformance test.
The 1st commit is from #30116, which started e2e services in a separate process.
The 2nd commit is from #30198, it statically linked etcd into the node e2e framework.
The 3rd commit is from #30200, it moved namespace controller into e2e services.
The 4th commit is new, it statically linked apiserver into the node e2e framework.
@dchen1107 @vishh
/cc @kubernetes/sig-node @kubernetes/sig-testing
This change is