Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Conformance Test: Start e2e services in a separate process #30116

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Aug 5, 2016

For #30122.

This is the first step of #30174.

This PR added a start-services-only mode in the test suite, and start all e2e services in a separate process by run the test binary again in start-services-only mode.


This change is Reviewable

@Random-Liu Random-Liu added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. area/node-e2e labels Aug 5, 2016
@Random-Liu Random-Liu added this to the v1.4 milestone Aug 5, 2016
@Random-Liu Random-Liu changed the title Node E2E: Start e2e services in a separate Node Conformance Test: Start e2e services in a separate Aug 5, 2016
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Aug 5, 2016
@Random-Liu Random-Liu force-pushed the start-e2e-services-in-separate-process branch from 0e9eb42 to a1548ac Compare August 5, 2016 04:00
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 5, 2016
@Random-Liu Random-Liu force-pushed the start-e2e-services-in-separate-process branch from a1548ac to 8088f4a Compare August 5, 2016 04:42
@Random-Liu Random-Liu changed the title Node Conformance Test: Start e2e services in a separate Node Conformance Test: Start e2e services in a separate process Aug 5, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2016
@Random-Liu Random-Liu force-pushed the start-e2e-services-in-separate-process branch from 8088f4a to b82eea9 Compare August 5, 2016 17:50
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2016
@Random-Liu Random-Liu force-pushed the start-e2e-services-in-separate-process branch from b82eea9 to bb3ff95 Compare August 7, 2016 00:37
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2016
func init() {
framework.RegisterCommonFlags()
framework.RegisterNodeFlags()
}

func TestE2eNode(t *testing.T) {
flag.Parse()
if *startServicesOnly {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this mode needed?

@Random-Liu
Copy link
Member Author

Mark P2 because there are 5 PRs relying on this one. And one of them is marked P1 to resolve the gci flake.

@Random-Liu Random-Liu added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 15, 2016
@k8s-bot
Copy link

k8s-bot commented Aug 15, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #30462.

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit 3910a66.

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #30462.

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #30719

@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-bot
Copy link

k8s-bot commented Aug 17, 2016

GCE e2e build/test passed for commit 3910a66.

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #30719

@k8s-bot
Copy link

k8s-bot commented Aug 17, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 17, 2016

GCE e2e build/test passed for commit 3910a66.

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #IGNORE.

@k8s-bot
Copy link

k8s-bot commented Aug 17, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Aug 17, 2016

GCE e2e build/test passed for commit 3910a66.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 457a151 into kubernetes:master Aug 17, 2016
@Random-Liu Random-Liu deleted the start-e2e-services-in-separate-process branch August 17, 2016 07:27
k8s-github-robot pushed a commit that referenced this pull request Aug 20, 2016
…o-services

Automatic merge from submit-queue

Node Conformance Test: Move namespace controller to services

For #30122, #30174.
Based on #30116, #30198.

**Please only review the 3rd PR.**

This PR is part of our roadmap to package node conformance test.
The 1st commit is from #30116, which started e2e services in a separate process.
The 2nd commit is from #30198, it statically linked etcd into the node e2e framework.

The 3rd commit is new, it moved namespace controller into e2e services.

@dchen1107 @vishh 
/cc @kubernetes/sig-node @kubernetes/sig-testing
k8s-github-robot pushed a commit that referenced this pull request Aug 21, 2016
Automatic merge from submit-queue

Node Conformance Test: Statically link apiserver

For #30122, #30174.
Based on #30116, #30198, #30200.

**Please only review the 4th PR.**

This PR is part of our roadmap to package node conformance test.
The 1st commit is from #30116, which started e2e services in a separate process.
The 2nd commit is from #30198, it statically linked etcd into the node e2e framework.
The 3rd commit is from #30200, it moved namespace controller into e2e services.

The 4th commit is new, it statically linked apiserver into the node e2e framework.

@dchen1107 @vishh 
/cc @kubernetes/sig-node @kubernetes/sig-testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/node-e2e area/test lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants