-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node Conformance Test: Start e2e services in a separate process #30116
Node Conformance Test: Start e2e services in a separate process #30116
Conversation
0e9eb42
to
a1548ac
Compare
a1548ac
to
8088f4a
Compare
8088f4a
to
b82eea9
Compare
b82eea9
to
bb3ff95
Compare
func init() { | ||
framework.RegisterCommonFlags() | ||
framework.RegisterNodeFlags() | ||
} | ||
|
||
func TestE2eNode(t *testing.T) { | ||
flag.Parse() | ||
if *startServicesOnly { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this mode needed?
Mark P2 because there are 5 PRs relying on this one. And one of them is marked P1 to resolve the gci flake. |
GCE e2e build/test passed for commit 3910a66. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3910a66. |
GCE e2e build/test passed for commit 3910a66. |
GCE e2e build/test passed for commit 3910a66. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3910a66. |
GCE e2e build/test passed for commit 3910a66. |
GCE e2e build/test passed for commit 3910a66. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3910a66. |
@k8s-bot test this issue #IGNORE. |
GCE e2e build/test passed for commit 3910a66. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3910a66. |
Automatic merge from submit-queue |
…o-services Automatic merge from submit-queue Node Conformance Test: Move namespace controller to services For #30122, #30174. Based on #30116, #30198. **Please only review the 3rd PR.** This PR is part of our roadmap to package node conformance test. The 1st commit is from #30116, which started e2e services in a separate process. The 2nd commit is from #30198, it statically linked etcd into the node e2e framework. The 3rd commit is new, it moved namespace controller into e2e services. @dchen1107 @vishh /cc @kubernetes/sig-node @kubernetes/sig-testing
Automatic merge from submit-queue Node Conformance Test: Statically link apiserver For #30122, #30174. Based on #30116, #30198, #30200. **Please only review the 4th PR.** This PR is part of our roadmap to package node conformance test. The 1st commit is from #30116, which started e2e services in a separate process. The 2nd commit is from #30198, it statically linked etcd into the node e2e framework. The 3rd commit is from #30200, it moved namespace controller into e2e services. The 4th commit is new, it statically linked apiserver into the node e2e framework. @dchen1107 @vishh /cc @kubernetes/sig-node @kubernetes/sig-testing
For #30122.
This is the first step of #30174.
This PR added a
start-services-only
mode in the test suite, and start all e2e services in a separate process by run the test binary again instart-services-only
mode.This change is![Reviewable](https://camo.githubusercontent.com/bdad2d5a4be7a00dc3b2426ea57eabd73ef84d8ed5ee05653b2f1501b6ea93ab/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)