Move UTs that block on apiserver to integration tests. #30634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
timothysc
added
release-note-none
|
I think I'm fine with this PR. But please fix tests. |
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
87f636b
to
e9e78d7
Compare
|
re: GKE tests, I don't see how this change could effect it. It's strictly a UT->Integ change and the GKE test is failing on some cluster bring-up. |
|
@k8s-bot test this issue: #IGNORE |
| @@ -196,3 +196,6 @@ test/integration/openshift | |||
| test/soak/cauldron | |||
| test/soak/serve_hostnames | |||
| third_party/forked/golang/expansion | |||
| test/integration/discoverysummarizer | |||
There was a problem hiding this comment.
What's this "linted packages"?
There was a problem hiding this comment.
It's part of the verify scripts, it's why it failed last time.
|
lgtm |
k8s-github-robot
added
the
needs-rebase
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
e9e78d7
to
40fb757
Compare
k8s-github-robot
removed
the
needs-rebase
|
Tests are failing. |
k8s-github-robot
added
the
needs-rebase
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
40fb757
to
cc437d2
Compare
k8s-github-robot
removed
the
needs-rebase
|
There is no way those error(s) are from this PR. |
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
cc437d2
to
0d5af31
Compare
|
LGTM |
wojtek-t
added
the
lgtm
timothysc
added
the
priority/backlog
k8s-github-robot
added
the
needs-rebase
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
0d5af31
to
261f1e2
Compare
k8s-github-robot
removed
lgtm
timothysc
added
the
lgtm
|
@k8s-bot test this please, issue #IGNORE |
k8s-github-robot
added
the
needs-rebase
…ver being fully stood up should be integration tests, not unit tests.
timothysc
force-pushed
the
etcd3_shouldbe_intergration_tests
branch
from
261f1e2
to
d6606a6
Compare
k8s-github-robot
removed
lgtm
timothysc
added
the
lgtm
|
@k8s-bot test this please, issue #IGNORE |
|
GCE e2e build/test passed for commit d6606a6. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Sorry it is not clear to me why should these tests be in integration and not unit tests? They are not trying to bring up multiple components, just testing the Run method in their respective classes. |
|
GCE e2e build/test passed for commit d6606a6. |
|
Automatic merge from submit-queue |
|
@nikhiljindal If you wish to standup the apiserver using a v3client you need a running etcd3. These tests expected the apiserver to be running. |
30 tasks
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 23, 2016
Automatic merge from submit-queue Enable v3 Client as the default on UTs Updates the default initialization to use clientv3 interface to etcd3, and fixes the UTs. This PR includes a cherry-pick of #30634 so we can validate the tests, so do not merge until that PR is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In validating etcd.v3client we had uncovered that a change in the behavior of the client etcd-io/etcd#6162 , caused a number of unit tests to fail. These test failures were due to the fact that the unit tests were trying to standup a apiserver even though there was no etcd backend stood up.
This PR simply shuffles those tests to integration tests, which is where they should be.
/cc @kubernetes/sig-scalability @wojtek-t @hongchaodeng @xiang90
This change is