-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod and qos level cgroup support #31546
pod and qos level cgroup support #31546
Conversation
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Picking this back up now for 1.5 release. Will start sending discrete PRs. |
ab72f72
to
8a5afc3
Compare
8a5afc3
to
04e8e5c
Compare
This PR is replacing the referenced item as it abstracts across cgroup drivers which required significant changes in the interim. |
opencontainers/runc pr changes here: opencontainers/runc#1084 |
04e8e5c
to
6760c47
Compare
Recording so I do not forget: There are two issues that need resolution around naming.
When constructing the sandbox config, we need to have a way to convert internal names easily to concrete names, but always keeping the linux cgroupfs style syntax. Exposing
In this case, the dockershim would need to run docker info to see its configured cgroup driver, and then call a utility to convert that to the proper slice form in the case of systemd (i.e /BestEffort.slice/BestEffort-pod_xyz.slice) becomes BestEffort-pod_xyz.slice. That conversion can be shared in libcontainer utility. /cc @vishh as I think this captures what we agreed upon. |
24d320a
to
babd430
Compare
@dubstack @vishh -- i can manually verify pod level cgroup creation AND deletion works as expected on systemd driver now, need to do a lot more testing and cleanup, but this will be the basis for breaking this uber PR into a number of smaller pulls. either way, i was happy to see everything is getting cleaned up on the cgroupfs filesystem as expected. |
99cbd72
to
a645ce2
Compare
CLAs look good, thanks! |
0a65fa8
to
1d0846b
Compare
1d0846b
to
42289c2
Compare
@vishh -- this should be good. |
Reviewed 9 of 30 files at r13, 1 of 10 files at r14, 4 of 11 files at r15, 20 of 20 files at r18. Comments from Reviewable |
Bumping priority since @derekwaynecarr cannot shepherd this PR beyond today until the code freeze and this PR is necessary for v1.5. |
@derekwaynecarr Given that this feature is |
Chatted with @derekwaynecarr offline. We decided to prefix the cgroup related flags with an |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
…groups Automatic merge from submit-queue pod and qos level cgroup support ```release-note [Kubelet] Add alpha support for `--cgroups-per-qos` using the configured `--cgroup-driver`. Disabled by default. ```
This change is