Implement basic admission control framework #3248
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| Copyright 2014 Google Inc. All rights reserved. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package admission | ||
|
|
||
| import ( | ||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime" | ||
| ) | ||
|
|
||
| type attributesRecord struct { | ||
| namespace string | ||
| kind string | ||
| operation string | ||
| object runtime.Object | ||
| } | ||
|
|
||
| func NewAttributesRecord(object runtime.Object, namespace, kind, operation string) Attributes { | ||
| return &attributesRecord{ | ||
| namespace: namespace, | ||
| kind: kind, | ||
| operation: operation, | ||
| object: object, | ||
| } | ||
| } | ||
|
|
||
| func (record *attributesRecord) GetNamespace() string { | ||
| return record.namespace | ||
| } | ||
|
|
||
| func (record *attributesRecord) GetKind() string { | ||
| return record.kind | ||
| } | ||
|
|
||
| func (record *attributesRecord) GetOperation() string { | ||
| return record.operation | ||
| } | ||
|
|
||
| func (record *attributesRecord) GetObject() runtime.Object { | ||
| return record.object | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| Copyright 2014 Google Inc. All rights reserved. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package admission | ||
|
|
||
| import ( | ||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/client" | ||
| ) | ||
|
|
||
| // chainAdmissionHandler is an instance of admission.Interface that performs admission control using a chain of admission handlers | ||
| type chainAdmissionHandler []Interface | ||
|
|
||
| // New returns an admission.Interface that will enforce admission control decisions | ||
| func NewFromPlugins(client client.Interface, pluginNames []string, configFilePath string) Interface { | ||
| plugins := []Interface{} | ||
| for _, pluginName := range pluginNames { | ||
| plugin := InitPlugin(pluginName, client, configFilePath) | ||
| if plugin != nil { | ||
| plugins = append(plugins, plugin) | ||
| } | ||
| } | ||
| return chainAdmissionHandler(plugins) | ||
| } | ||
|
|
||
| // Admit performs an admission control check using a chain of handlers, and returns immediately on first error | ||
| func (admissionHandler chainAdmissionHandler) Admit(a Attributes) (err error) { | ||
| for _, handler := range admissionHandler { | ||
| err := handler.Admit(a) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| Copyright 2014 Google Inc. All rights reserved. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package admission | ||
|
|
||
| import ( | ||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime" | ||
| ) | ||
|
|
||
| // Attributes is an interface used by AdmissionController to get information about a request | ||
| // that is used to make an admission decision. | ||
| type Attributes interface { | ||
| GetNamespace() string | ||
| GetKind() string | ||
| GetOperation() string | ||
| GetObject() runtime.Object | ||
| } | ||
|
|
||
| // Interface is an abstract, pluggable interface for Admission Control decisions. | ||
| type Interface interface { | ||
| // Admit makes an admission decision based on the request attributes | ||
| Admit(a Attributes) (err error) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| Copyright 2014 Google Inc. All rights reserved. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package admission | ||
|
|
||
| import ( | ||
| "io" | ||
| "os" | ||
| "sync" | ||
|
|
||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/client" | ||
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| // Factory is a function that returns a Interface for admission decisions. | ||
| // The config parameter provides an io.Reader handler to the factory in | ||
| // order to load specific configurations. If no configuration is provided | ||
| // the parameter is nil. | ||
| type Factory func(client client.Interface, config io.Reader) (Interface, error) | ||
|
|
||
| // All registered admission options. | ||
| var pluginsMutex sync.Mutex | ||
| var plugins = make(map[string]Factory) | ||
|
|
||
| // GetPlugins enumerates the | ||
| func GetPlugins() []string { | ||
| pluginsMutex.Lock() | ||
| defer pluginsMutex.Unlock() | ||
| keys := []string{} | ||
| for k := range plugins { | ||
| keys = append(keys, k) | ||
| } | ||
| return keys | ||
| } | ||
|
|
||
| // RegisterPlugin registers a plugin Factory by name. This | ||
| // is expected to happen during app startup. | ||
| func RegisterPlugin(name string, plugin Factory) { | ||
| pluginsMutex.Lock() | ||
| defer pluginsMutex.Unlock() | ||
| _, found := plugins[name] | ||
| if found { | ||
| glog.Fatalf("Admission plugin %q was registered twice", name) | ||
| } | ||
| glog.V(1).Infof("Registered admission plugin %q", name) | ||
| plugins[name] = plugin | ||
| } | ||
|
|
||
| // GetInterface creates an instance of the named plugin, or nil if | ||
| // the name is not known. The error return is only used if the named provider | ||
| // was known but failed to initialize. The config parameter specifies the | ||
| // io.Reader handler of the configuration file for the cloud provider, or nil | ||
| // for no configuration. | ||
| func GetPlugin(name string, client client.Interface, config io.Reader) (Interface, error) { | ||
| pluginsMutex.Lock() | ||
| defer pluginsMutex.Unlock() | ||
| f, found := plugins[name] | ||
| if !found { | ||
| return nil, nil | ||
| } | ||
| return f(client, config) | ||
| } | ||
|
|
||
| // InitPlugin creates an instance of the named interface | ||
| func InitPlugin(name string, client client.Interface, configFilePath string) Interface { | ||
| var config *os.File | ||
|
|
||
| if name == "" { | ||
| glog.Info("No admission plugin specified.") | ||
| return nil | ||
| } | ||
|
|
||
| if configFilePath != "" { | ||
| var err error | ||
|
|
||
| config, err = os.Open(configFilePath) | ||
| if err != nil { | ||
| glog.Fatalf("Couldn't open admission plugin configuration %s: %#v", | ||
| configFilePath, err) | ||
| } | ||
|
|
||
| defer config.Close() | ||
| } | ||
|
|
||
| plugin, err := GetPlugin(name, client, config) | ||
| if err != nil { | ||
| glog.Fatalf("Couldn't init admission plugin %q: %v", name, err) | ||
| } | ||
| if plugin == nil { | ||
| glog.Fatalf("Unknown admission plugin: %s", name) | ||
| } | ||
|
|
||
| return plugin | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need an else clause like some other options have above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Absence of a value will just cause kube-apiserver to take the default "AlwaysAdmit"