MinReadySeconds / AvailableReplicas for ReplicaSets #32771

0xmichalis · 2016-09-15T10:13:55Z

This PR adds minReadySeconds and availableReplicas for replica sets / replication controllers

Partially addresses #28381

cc: @mfojtik

@bgrant0607 for the api changes, @janetkuo for controller changes

This change is

k8s-bot · 2016-09-19T17:00:20Z

GCE e2e build/test passed for commit 61e1a145cc29eb8664fac913c3804fed3a0658d4.

0xmichalis · 2016-09-21T13:24:39Z

@k8s-bot gce e2e test this issue: #31776

k8s-ci-robot · 2016-09-21T14:33:57Z

Jenkins GCE e2e failed for commit d7dd751.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

bgrant0607 · 2016-09-22T23:53:07Z

API change LGTM

janetkuo · 2016-09-23T00:10:48Z

pkg/api/resource_helpers.go

+// 1. minReadySeconds == 0, or
+// 2. LastTransitionTime (is set) + minReadySeconds < current time
+func IsPodAvailable(pod *Pod, minReadySeconds int32, now unversioned.Time) bool {
+	if !IsPodReady(pod) {


Should we exclude inactive ones, i.e. the ones that succeeded, failed, or are terminating? If we're changing this, add this test case.

Not in this level. I wanted to keep IsPodAvailable merely as an incremental addition on top of IsPodReady. Callers should decide if they want to filter succeeded/failed/terminating pods, similar to how we use IsPodReady in the replica set and rc controllers.

janetkuo · 2016-09-23T00:25:05Z

pkg/api/types.go

@@ -1739,6 +1744,9 @@ type ReplicationControllerStatus struct {
 	// The number of ready replicas for this replication controller.
 	ReadyReplicas int32 `json:"readyReplicas,omitempty"`

+	// The number of available replicas for this replication controller.


explain what "available" means in the comment (how is it different from ready ones, and mention minreadyseconds)

janetkuo · 2016-09-23T00:25:46Z

pkg/api/v1/types.go

@@ -2050,6 +2055,9 @@ type ReplicationControllerStatus struct {
 	// The number of ready replicas for this replication controller.
 	ReadyReplicas int32 `json:"readyReplicas,omitempty" protobuf:"varint,4,opt,name=readyReplicas"`

+	// The number of available replicas for this replication controller.


janetkuo · 2016-09-23T00:34:22Z

pkg/apis/extensions/types.go

@@ -632,6 +637,9 @@ type ReplicaSetStatus struct {
 	// The number of ready replicas for this replica set.
 	ReadyReplicas int32 `json:"readyReplicas,omitempty"`

+	// The number of available replicas for this replica set.
+	AvailableReplicas int32 `json:"availableReplicas,omitempty"`


k8s-github-robot · 2016-09-23T09:50:48Z

@k8s-ci-robot
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

0xmichalis · 2016-09-23T09:53:45Z

@k8s-bot unit test this issue: #31729

janetkuo · 2016-09-23T17:18:36Z

pkg/controller/replicaset/replica_set_test.go

+	fakePodControl := controller.FakePodControl{}
+	manager.podControl = &fakePodControl
+
+	// The controller checks for available pods at 00:21 - it shoud see only one available pod.


janetkuo · 2016-09-23T17:24:10Z

pkg/controller/replicaset/replica_set_test.go

+
+	// The controller checks for available pods at 00:21 - it shoud see only one available pod.
+	now = func() unversioned.Time { return unversioned.Date(2016, 11, 13, 0, 0, 21, 0, time.UTC) }
+	manager.syncReplicaSet(getKey(rs, t))


Is now only used here (in the unit test)? Why not just declare it here?

Yes, it's used only for unit testing but we need to declare it in replica_set.go since it's part of it.:)

Ah, now I see what now is for. Could you instead create a private function in manager/ReplicaSetController (e.g. setNow()) that does what now did? It'd be more clear IMO.

janetkuo · 2016-09-26T22:43:08Z

Fix the typo and the last suggestion then I have no more comments

bgrant0607 · 2016-09-27T16:13:17Z

pkg/api/types.go

+	// Minimum number of seconds for which a newly created pod should be ready
+	// without any of its container crashing, for it to be considered available.
+	// Defaults to 0 (pod will be considered available as soon as it is ready)
+	MinReadySeconds int32 `json:"minReadySeconds,omitempty"`


Please put this last in the spec, after Template.

bgrant0607 · 2016-09-27T16:20:47Z

We're going to add minReadySeconds to all controllers. We should consider adding it to PodSpec, but version skew (Kubelets not supporting it) would make it hard to rely on, so I'm ok with this for now.

k8s-ci-robot · 2016-09-27T19:55:21Z

Jenkins verification failed for commit af01ebcf917631223d3b9b5d06b7d0ac845acf61. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-09-27T20:02:52Z

Jenkins GCI GKE smoke e2e failed for commit af01ebcf917631223d3b9b5d06b7d0ac845acf61. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

janetkuo · 2016-09-27T21:06:00Z

@k8s-bot gke e2e test this #33361

0xmichalis · 2016-09-28T09:32:16Z

rebased, reapplying lgtm

0xmichalis · 2016-09-28T10:23:44Z

@k8s-bot test this issue: #33388

0xmichalis · 2016-09-28T11:09:59Z

@k8s-bot gke test this issue: #33617

k8s-ci-robot · 2016-09-28T11:53:17Z

Jenkins GKE smoke e2e failed for commit d8dc2aa. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-github-robot · 2016-09-28T12:40:10Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2016-09-28T13:17:54Z

Automatic merge from submit-queue

@nikhiljindal

…ler-ready-available-replicas Automatic merge from submit-queue populate ready replicas and aviable replicas to federated replicaset … populate ready replicas and aviable replicas to federated replicaset status @nikhiljindal #33312 #29481 #32771 @deepak-vij

googlebot added the cla: yes label Sep 15, 2016

0xmichalis assigned bgrant0607 and janetkuo Sep 15, 2016

k8s-github-robot mentioned this pull request Sep 15, 2016

[k8s.io] Kubectl client [k8s.io] Kubectl run --quiet job should not output anything except the command when --quiet is set {Kubernetes e2e suite} #32548

Closed

0xmichalis mentioned this pull request Sep 18, 2016

Add perma-failed deployments API #19343

Merged

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2016

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 19, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2016

bgrant0607 added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Sep 22, 2016

janetkuo reviewed Sep 23, 2016

View reviewed changes

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2016

janetkuo reviewed Sep 23, 2016

View reviewed changes

bgrant0607 reviewed Sep 27, 2016

View reviewed changes

bgrant0607 removed their assignment Sep 27, 2016

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2016

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016

0xmichalis added 3 commits September 28, 2016 11:06

extensions: add minReadySeconds/availableReplicas to replica sets

f7c232b

Custom conversion reactions to minReadySeconds/availableReplicas

1df4ee3

extensions: generated code for minReadySeconds/availableReplicas

d8dc2aa

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2016

0xmichalis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2016

k8s-github-robot merged commit 5af1b25 into kubernetes:master Sep 28, 2016

k8s-github-robot mentioned this pull request Sep 28, 2016

[k8s.io] Downward API volume should update labels on modification [Conformance] {E2eNode Suite} #33423

Closed

0xmichalis deleted the minReadySecondsForRS branch September 28, 2016 13:41

0xmichalis mentioned this pull request Oct 22, 2016

Add readyReplicas to Deployments #28381

Closed

This was referenced Nov 10, 2016

federation: verify and add tests for replicaset preferences annotations #33312

Closed

populate ready replicas and aviable replicas to federated replicaset … #36602

Merged

bgrant0607 mentioned this pull request Mar 9, 2017

Proposal: Introduce Available Pods (MinReadySeconds in the PodSpec) kubernetes/community#194

Closed

bgrant0607 mentioned this pull request Mar 21, 2017

Workload API v1 requirements umbrella issue #42752

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MinReadySeconds / AvailableReplicas for ReplicaSets #32771

MinReadySeconds / AvailableReplicas for ReplicaSets #32771

0xmichalis commented Sep 15, 2016 •

edited by k8s-oncall

Loading

k8s-bot commented Sep 19, 2016

0xmichalis commented Sep 21, 2016

k8s-ci-robot commented Sep 21, 2016

bgrant0607 commented Sep 22, 2016

janetkuo Sep 23, 2016 •

edited

Loading

0xmichalis Sep 23, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 23, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 23, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 23, 2016

k8s-github-robot commented Sep 23, 2016

0xmichalis commented Sep 23, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 27, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 23, 2016

janetkuo Sep 23, 2016

0xmichalis Sep 24, 2016

janetkuo commented Sep 26, 2016

bgrant0607 Sep 27, 2016

0xmichalis Sep 27, 2016

bgrant0607 commented Sep 27, 2016

k8s-ci-robot commented Sep 27, 2016

k8s-ci-robot commented Sep 27, 2016

janetkuo commented Sep 27, 2016

0xmichalis commented Sep 28, 2016

0xmichalis commented Sep 28, 2016

0xmichalis commented Sep 28, 2016

k8s-ci-robot commented Sep 28, 2016

k8s-github-robot commented Sep 28, 2016

k8s-github-robot commented Sep 28, 2016

MinReadySeconds / AvailableReplicas for ReplicaSets #32771

MinReadySeconds / AvailableReplicas for ReplicaSets #32771

Conversation

0xmichalis commented Sep 15, 2016 • edited by k8s-oncall Loading

k8s-bot commented Sep 19, 2016

0xmichalis commented Sep 21, 2016

k8s-ci-robot commented Sep 21, 2016

bgrant0607 commented Sep 22, 2016

janetkuo Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-github-robot commented Sep 23, 2016

0xmichalis commented Sep 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janetkuo commented Sep 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgrant0607 commented Sep 27, 2016

k8s-ci-robot commented Sep 27, 2016

k8s-ci-robot commented Sep 27, 2016

janetkuo commented Sep 27, 2016

0xmichalis commented Sep 28, 2016

0xmichalis commented Sep 28, 2016

0xmichalis commented Sep 28, 2016

k8s-ci-robot commented Sep 28, 2016

k8s-github-robot commented Sep 28, 2016

k8s-github-robot commented Sep 28, 2016

0xmichalis commented Sep 15, 2016 •

edited by k8s-oncall

Loading

janetkuo Sep 23, 2016 •

edited

Loading