Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl describe: show multiple labels/annotations on multiple lines. #32893

Merged
merged 1 commit into from
Sep 17, 2016
Merged

kubectl describe: show multiple labels/annotations on multiple lines. #32893

merged 1 commit into from
Sep 17, 2016

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Sep 16, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it: cherrypick fix for #32699 from 72b4b54

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

Close #32699

(cherry picked from commit 72b4b54)

This change is Reviewable

@jessfraz
kubectl describe: show multiple labels/annotations on multiple lines.
563c938 
When there is more than one label/annotation, it's more readable to see
them on the different lines.

(cherry picked from commit 72b4b54)
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 16, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 16, 2016

GCE e2e build/test passed for commit 563c938.

@jessfraz jessfraz added release-note-none Denotes a PR that doesn't merit a release note. kind/upgrade-test-failure and removed release-note-label-needed labels Sep 16, 2016
@jessfraz jessfraz added this to the 1.2 milestone Sep 16, 2016
@janetkuo janetkuo self-assigned this Sep 16, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@jessfraz jessfraz modified the milestones: v1.4, 1.2 Sep 16, 2016
@eparis eparis modified the milestones: v1.2, v1.4 Sep 16, 2016
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2016
@fejta fejta removed their assignment Sep 17, 2016
@pwittrock pwittrock merged commit 723de0f into kubernetes:release-1.2 Sep 17, 2016
@jessfraz jessfraz deleted the cherrypick-upgrade-fix branch September 17, 2016 17:44
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#32893 from jfrazelle/cherrypick-upgrade…
4c5e8d6 
…-fix

kubectl describe: show multiple labels/annotations on multiple lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

Labels
do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
9 participants
@jessfraz @k8s-github-robot @k8s-bot @k8s-cherrypick-bot @fejta @janetkuo @googlebot @pwittrock @eparis