Staging 1.5 client #32906
Staging 1.5 client #32906
Conversation
caesarxuchao
added
the
sig/api-machinery
k8s-github-robot
added
size/XXL
|
@k8s-bot test this, issue #IGNORE |
|
GCE e2e build/test passed for commit 74f26cb1f223ab305cad988db4c3d2f6dc07e802. |
|
Can you make the commit in the middle do a rename instead of having a delete & then recreate commit? Also test is red? Then lgtm. |
caesarxuchao
force-pushed
the
staging-1.5
branch
from
74f26cb
to
54524e8
Compare
|
I merged the commit, but github doesn't show them as renaming, maybe it's because too many files are moved. |
|
I think you may have dropped the second commit instead of squashing them, github says only +7 lines right now... |
|
No, I didn't drop it. Github is broken. |
caesarxuchao
force-pushed
the
staging-1.5
branch
from
54524e8
to
546f6a3
Compare
| extensions "k8s.io/client-go/1.4/pkg/apis/extensions/v1beta1" | ||
| policy "k8s.io/client-go/1.4/pkg/apis/policy/v1alpha1" | ||
| "k8s.io/client-go/1.4/pkg/util/intstr" | ||
| release_1_4 "k8s.io/client-go/1.5/kubernetes" |
There was a problem hiding this comment.
Nice catch. I remove the rename.
|
@caesarxuchao Also I think you want release-note-none. |
caesarxuchao
force-pushed
the
staging-1.5
branch
from
546f6a3
to
a4e6229
Compare
caesarxuchao
added
release-note-none
|
Can I get the label? Thanks. |
|
@lavalamp git doesn't actually have a way to track file rename/move operations. Instead it does "rename detection" when it tries to summarize a change to you. LGTM |
mml
added
the
lgtm
|
Jenkins GCE e2e failed for commit a4e6229. The magic incantation to run this job again is |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue Copy auth plugin to client-go repo client-go doesn't copy the [auth plugin](https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/client/auth/plugins.go). This causes user cannot access cluster run by GKE. User will see error "No Auth Provider found for name gcp". This PR fixes this issue. It's marked as WIP because I'll need to rebase after #32906 gets merged. Also, the fix needs to be cherry-picked into 1.4 branch to update client-go/1.4.
Created the 1.5 folder and remove the 1.4 folder in the staging area in the master branch.
Content of kubernetes/client-go/1.4 will be pulled from the kubernetes/kubernetes 1.4 branch (kubernetes-retired/contrib#1719)
This change is