Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Support default value for ExternalHost #33568

Merged
merged 1 commit into from
Nov 8, 2016
Merged

AWS: Support default value for ExternalHost #33568

merged 1 commit into from
Nov 8, 2016

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Sep 27, 2016 •
edited by k8s-oncall
Loading

Fix #33563

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Sep 27, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 4f81dcf66c2905b6297916571dc9ed92ff174b50. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@justinsb justinsb changed the title AWS: Support default for ExternalHost on AWS AWS: Support default value for ExternalHost Sep 28, 2016
@justinsb
Copy link
Member Author

@k8s-bot gci gke e2e test this

@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Sep 28, 2016
@justinsb
Copy link
Member Author

Rebased ... this is now even smaller @smarterclayton :-)

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 2c7771e. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2016
@smarterclayton
Copy link
Contributor

LGTM

@justinsb
Copy link
Member Author

justinsb commented Nov 1, 2016

@k8s-bot node e2e test this issue #34990

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 2c7771e. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@justinsb
Copy link
Member Author

justinsb commented Nov 4, 2016

@k8s-bot cvm gce e2e test this

@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

Release-czar approved post-code freeze merge--This was LGTMed and in the merge-queue at code freeze time for 1.5. Adding 1.5 milestone to let it gets merged after code freeze.

@saad-ali saad-ali added this to the v1.5 milestone Nov 8, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4dbc532 into kubernetes:master Nov 8, 2016
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@justinsb @k8s-ci-robot @smarterclayton @saad-ali @k8s-github-robot @googlebot