Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #33678 upstream release 1.4 #33808

Conversation

saad-ali
Copy link
Member

@saad-ali saad-ali commented Sep 30, 2016

Automated cherry pick of #33678 ("Increase timeout for downwardapi volume tests") upstream release 1.4

This is a test fix no code change.


This change is Reviewable

@pwittrock
Copy link
Member

@k8s-bot gke e2e test this

@pwittrock pwittrock added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 30, 2016
@pwittrock pwittrock added this to the v1.4 milestone Sep 30, 2016
@saad-ali
Copy link
Member Author

@k8s-bot gke e2e test this, Issue: #33672

@saad-ali
Copy link
Member Author

@k8s-bot gke e2e test this, Issue: #33617

@saad-ali
Copy link
Member Author

saad-ali commented Oct 1, 2016

@k8s-bot gke e2e test this, Issue: #33388

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 1cb0a95. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali
Copy link
Member Author

saad-ali commented Oct 1, 2016

Recommend manual merge at this point since 1) this is improving flaky test and 2) all the GKE smoke e2e flakes failing are unrelated to this PR.

@jessfraz jessfraz added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Oct 3, 2016
@jessfraz
Copy link
Contributor

jessfraz commented Oct 3, 2016

manual merge seems fine to me

@saad-ali
Copy link
Member Author

saad-ali commented Oct 3, 2016

Thanks Jess, manually merging

@saad-ali saad-ali merged commit 4fbf9cd into kubernetes:release-1.4 Oct 3, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@saad-ali saad-ali deleted the automated-cherry-pick-of-#33678-upstream-release-1.4 branch November 19, 2016 01:07
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ck-of-#33678-upstream-release-1.4

Automated cherry pick of kubernetes#33678 upstream release 1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants