-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local option to the label command #33990
Add local option to the label command #33990
Conversation
This was split out of #28949 |
@asalkeld Can you add a test to |
Oh, and while I'm thinking about it. |
be4feee
to
c2b8377
Compare
@deads2k I have added the test-cmd.sh test. I'll do the annotate one separately. |
Jenkins unit/integration failed for commit c2b8377fd271e543783cfda467c1ac2ddbf4b31f. Full PR test history. The magic incantation to run this job again is |
This is to be used with the new "set selector" command.
c2b8377
to
5cb945d
Compare
lgtm |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
What this PR does / why we need it:
Add the --local option to be both consistent with other commands and so it can be used with "set selector" and "create service".
Which issue this PR fixes
Related: #7296
Special notes for your reviewer:
None
Release note:
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)