Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local option to the label command #33990

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

asalkeld
Copy link

@asalkeld asalkeld commented Oct 4, 2016

What this PR does / why we need it:
Add the --local option to be both consistent with other commands and so it can be used with "set selector" and "create service".

Which issue this PR fixes
Related: #7296

Special notes for your reviewer:
None

Release note:

Add a new option "--local" to the `kubectl label`

This change is Reviewable

@asalkeld
Copy link
Author

asalkeld commented Oct 4, 2016

This was split out of #28949

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Oct 4, 2016
@deads2k deads2k assigned deads2k and unassigned j3ffml Oct 4, 2016
@deads2k deads2k added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Oct 4, 2016
@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2016

@asalkeld Can you add a test to test-cmd.sh. Then lgtm.

@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2016

@asalkeld Can you add a test to test-cmd.sh. Then lgtm.

Oh, and while I'm thinking about it. kubectl annotate too? I'd expect them to be closely related. Can be a separate pull if you wish.

@asalkeld
Copy link
Author

asalkeld commented Oct 5, 2016

@deads2k I have added the test-cmd.sh test. I'll do the annotate one separately.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit c2b8377fd271e543783cfda467c1ac2ddbf4b31f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@asalkeld
Copy link
Author

asalkeld commented Oct 5, 2016

@deads2k the annotate one is here: #34074

This is to be used with the new "set selector" command.
@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2016
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2016

lgtm

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 776af8e into kubernetes:master Oct 5, 2016
@asalkeld asalkeld deleted the local-option-label branch October 5, 2016 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants