Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified Federation Control Plane Deployment. #34484

Closed
wants to merge 8 commits into from
Closed

Simplified Federation Control Plane Deployment. #34484

wants to merge 8 commits into from

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Oct 10, 2016 •
edited
Loading

This is now moved to kubernetes/community#426

I am not entirely sure whom to assign this to for reviews since this spans multiple SIGs.

(Assigning it to myself for now to disable bot assignments).

@kubernetes/sig-cluster-federation @kubernetes/sig-cluster-lifecycle @kubernetes/sig-cli PTAL.

Note: The goal (and the plan) is to implement this in v1.5 time frame and will be considered "alpha".

cc @quinton-hoole @nikhiljindal @roberthbailey @mikedanese @allannaim @matchstick @irfanurrehman

This change is Reviewable

@madhusudancs madhusudancs added this to the next-candidate milestone Oct 10, 2016
@madhusudancs madhusudancs added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/cluster-federation sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed 0 - Backlog labels Oct 10, 2016
@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Oct 10, 2016
@madhusudancs madhusudancs assigned madhusudancs and unassigned thockin Oct 10, 2016
@madhusudancs madhusudancs added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 10, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit d7e177a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@pires
Copy link
Contributor

pires commented Oct 10, 2016 •
edited
Loading

This is definitely on the radar for @kubernetes/sig-cluster-lifecycle and we've mentioned it quite a few times when debating discovery, right @jbeda?

@madhusudancs
Copy link
Contributor Author

@pires Thanks! Comments and any feedback welcome.

@jbeda
Copy link
Contributor

jbeda commented Oct 11, 2016

Longer term I think this is certainly in scope for kubeadm and @kubernetes/sig-cluster-lifecycle. But for 1.5 (and probably a couple of releases after) we are going to be focused getting the single cluster case really rock solid. I'm not sure it is in the immediate plans for anyone currently involved there.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 604e018. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. kind/old-docs do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 1, 2016
k8s-github-robot pushed a commit that referenced this pull request Dec 8, 2016
Merge pull request #36310 from irfanurrehman/federation-kubefed-todo-1
702c33a 
Automatic merge from submit-queue

[Federation] Make federation etcd PVC size configurable

This one implements one of the many TODO items pending in the previous set of kubefed PRs.
The design doc PR is at #34484

cc  @kubernetes/sig-cluster-federation  @madhusudancs



**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
``` 
[Federation] kubefed init now has a new flag, --etcd-pv-capacity, which can be used to configure the persistent volume capacity for etcd.  
```
k8s-github-robot pushed a commit that referenced this pull request Dec 8, 2016
Merge pull request #36447 from irfanurrehman/federation-kubefed-todo-2
8182f17 
Automatic merge from submit-queue

[Federation] Implement dry run support in kubefed init

This one implements one of the TODO items pending in the previous set of kubefed PRs.
This one is done on top of another todo PR #36310 which is being reviewed separately.
Please review only the last 2 commits in this one.
The design doc PR for kubefed is at #34484.

cc  @kubernetes/sig-cluster-federation  @madhusudancs @nikhiljindal



**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
``` 
[Federation] `kubefed init` now supports dry run mode. 
```
@dims
Copy link
Member

dims commented Dec 9, 2016

@madhusudancs Move the milestone please if appropriate?

@timothysc
Copy link
Member

/cc @rrati

@madhusudancs madhusudancs modified the milestones: v1.6, v1.5 Dec 9, 2016
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@matchstick matchstick added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 31, 2017
@matchstick
Copy link
Contributor

@madhusudancs brought this to my attention. It looks like the implementation matches what is in this PR. I am going to mark this LGTM.

If that is incorrect for some reason (not appropriate, or anyone objects) please someone pipe up. @madhusudancs was having trouble with anyone weighing in one way or the other.

@matchstick matchstick added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 31, 2017
@k8s-github-robot
Copy link

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 2, 2017
@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (May 1, 2017).

cc @brendandburns @madhusudancs @matchstick

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@madhusudancs madhusudancs mentioned this pull request Mar 2, 2017
Closed
@madhusudancs
Copy link
Contributor Author

This is now moved to kubernetes/community#426. Closing this PR.

perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this pull request Sep 2, 2017
Merge pull request #36310 from irfanurrehman/federation-kubefed-todo-1
e4a42e6 
Automatic merge from submit-queue

[Federation] Make federation etcd PVC size configurable

This one implements one of the many TODO items pending in the previous set of kubefed PRs.
The design doc PR is at kubernetes/kubernetes#34484

cc  @kubernetes/sig-cluster-federation  @madhusudancs



**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
``` 
[Federation] kubefed init now has a new flag, --etcd-pv-capacity, which can be used to configure the persistent volume capacity for etcd.  
```
perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this pull request Sep 2, 2017
Merge pull request #36447 from irfanurrehman/federation-kubefed-todo-2
f34263d 
Automatic merge from submit-queue

[Federation] Implement dry run support in kubefed init

This one implements one of the TODO items pending in the previous set of kubefed PRs.
This one is done on top of another todo PR kubernetes/kubernetes#36310 which is being reviewed separately.
Please review only the last 2 commits in this one.
The design doc PR for kubefed is at kubernetes/kubernetes#34484.

cc  @kubernetes/sig-cluster-federation  @madhusudancs @nikhiljindal



**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
``` 
[Federation] `kubefed init` now supports dry run mode. 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@adohe-zz adohe-zz adohe-zz left review comments

@irfanurrehman irfanurrehman irfanurrehman left review comments

@nikhiljindal nikhiljindal nikhiljindal left review comments

@smarterclayton smarterclayton smarterclayton requested changes

Assignees

@madhusudancs madhusudancs

@brendandburns brendandburns

@matchstick matchstick

Labels
do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet