New client-go structure #34989
New client-go structure #34989
Conversation
convert e2e tests of client-go to use version options
k8s-github-robot
added
size/XXL
| extensions "k8s.io/client-go/1.5/pkg/apis/extensions/v1beta1" | ||
| policy "k8s.io/client-go/1.5/pkg/apis/policy/v1alpha1" | ||
| "k8s.io/client-go/1.5/pkg/util/intstr" | ||
| "k8s.io/client-go/kubernetes" |
There was a problem hiding this comment.
I guess my test was the only one that was using 1.5 directly. This rename looks easy, but what if some test wants to use an old API. For example, suppose we have some bug that was tickled specifically by, say, the 1.3 client. Will we be able to write such tests?
I'm guessing if anyone wants to write a test like that, they'll have to specifically vendor in that version of the client.
|
You need a release note, but LGTM. |
mml
added
the
lgtm
k8s-github-robot
added
the
do-not-merge
caesarxuchao
added
release-note-action-required
|
Actually I don't think we need a release note. The new versioning plan is described in the README file of the client-go repository. I marked it as |
|
Jenkins GCI GKE smoke e2e failed for commit 923757f. Full PR test history. The magic incantation to run this job again is |
|
Automatic merge from submit-queue |
This PR is part of restructuring client-go (kubernetes/client-go#9 (comment)). In short, the top-level folder for client-go versions are removed.
This PR also runs copy.sh to pick up changes in the main repository. The number of files in client-go has increase from 1361 files to 1405.
@mbohlool @mml @timoreimann
This change is