Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow apiserver to choose preferred kubelet address type #35497

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Allow apiserver to choose preferred kubelet address type #35497

merged 1 commit into from
Nov 1, 2016

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 25, 2016 •
edited
Loading

Follow up to #33718 to stay compatible with clusters using DNS names for master->node communications. Adds the --kubelet-preferred-address-types apiserver flag for clusters that prefer a different node address type.

The apiserver can now select which type of kubelet-reported address to use for apiserver->node communications, using the --kubelet-preferred-address-types flag.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Oct 25, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 0230774a2aa6959481d390175f6ef99cb3f2252a. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 0230774a2aa6959481d390175f6ef99cb3f2252a. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 0230774a2aa6959481d390175f6ef99cb3f2252a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 0230774a2aa6959481d390175f6ef99cb3f2252a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 0230774a2aa6959481d390175f6ef99cb3f2252a. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt liggitt mentioned this pull request Oct 25, 2016
Merged
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Oct 25, 2016
@liggitt liggitt added this to the v1.5 milestone Oct 25, 2016
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2016
@liggitt liggitt force-pushed the node-address branch 3 times, most recently from 6e74a7a to 00b2be9 Compare October 25, 2016 06:54
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 00b2be994e68f526f494231bfaefc7d1a038ba88. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt liggitt mentioned this pull request Oct 25, 2016
Closed
@liggitt
Copy link
Member Author

liggitt commented Oct 26, 2016

@justinsb PTAL

@liggitt liggitt assigned smarterclayton and unassigned justinsb Oct 31, 2016
@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2016
@smarterclayton
Copy link
Contributor

LGTM

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 4b72045106b5b7d1dddb3641ad2914df59196245. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt
Copy link
Member Author

liggitt commented Oct 31, 2016

@k8s-bot node e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 4b72045106b5b7d1dddb3641ad2914df59196245. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@liggitt
Copy link
Member Author

liggitt commented Oct 31, 2016 •
edited
Loading

update test_owners.csv (#35850)

@liggitt liggitt added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 31, 2016
@liggitt
Copy link
Member Author

liggitt commented Oct 31, 2016 •
edited
Loading

#35898 flake
@k8s-bot unit test this

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 1a7f7c5. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d461262 into kubernetes:master Nov 1, 2016
@liggitt liggitt deleted the node-address branch November 6, 2016 05:30
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@liggitt liggitt mentioned this pull request Dec 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-ci-robot @smarterclayton @k8s-github-robot @justinsb @googlebot