Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds option to set CLOSE_WAIT timeout from kube-proxy, adjusts default timeout to 1 hour #35919

Merged
merged 4 commits into from
Nov 4, 2016
Merged

Adds option to set CLOSE_WAIT timeout from kube-proxy, adjusts default timeout to 1 hour #35919

merged 4 commits into from
Nov 4, 2016

Conversation

bowei
Copy link
Member

@bowei bowei commented Oct 31, 2016 •
edited by jessfraz
Loading 

Adds TCPCloseWaitTimeout option to kube-proxy for sysctl nf_conntrack_tcp_timeout_time_wait

Fixes issue #32551

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 250d44f43cc826ffb4ef5dd7301b54daee2bf5ce. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@spxtr spxtr assigned freehan and unassigned spxtr Oct 31, 2016
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 09ba937498d3718fad05e9ae8cf8dddb3fda2dc0. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 09ba937498d3718fad05e9ae8cf8dddb3fda2dc0. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 8394523d017a2fe38d3c6020d2f07ee7e77239be. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit ad32c020855f88d5b695892e02ceb9a3d8914676. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit ad32c020855f88d5b695892e02ceb9a3d8914676. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit ad32c020855f88d5b695892e02ceb9a3d8914676. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit ad32c020855f88d5b695892e02ceb9a3d8914676. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bowei
Copy link
Member Author

bowei commented Nov 1, 2016

@bprashanth @thockin

thockin
thockin reviewed Nov 1, 2016
View reviewed changes
pkg/apis/componentconfig/v1alpha1/defaults.go
@@ -101,6 +101,9 @@ func SetDefaults_KubeProxyConfiguration(obj *KubeProxyConfiguration) {
if obj.ConntrackTCPEstablishedTimeout == zero {
obj.ConntrackTCPEstablishedTimeout = unversioned.Duration{Duration: 24 * time.Hour} // 1 day (1/5 default)
}
if obj.ConntrackTCPCloseWaitTimeout == zero {
obj.ConntrackTCPCloseWaitTimeout = unversioned.Duration{Duration: 1 * time.Hour}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment explainign why we chose this?

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 1, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit ec01aabf084d64cf88f0fa4dfde206dc08042177. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 4, 2016
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3dec88d into kubernetes:master Nov 4, 2016
@jessfraz jessfraz modified the milestones: v1.5, v1.4 Nov 4, 2016
@jessfraz jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 8, 2016
@jessfraz jessfraz mentioned this pull request Nov 9, 2016
Merged
@jessfraz
Copy link
Contributor

jessfraz commented Nov 9, 2016

cherry-picked in #36510

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 9, 2016
jessfraz added a commit that referenced this pull request Nov 9, 2016
@jessfraz
Merge pull request #36510 from jessfraz/automated-cherry-pick-of-#34375-
d72ad89 
#35285-#35420-#35608-#35919-#36161-origin-release-1.4

Automated cherry pick of #34375 #35285 #35420 #35608 #35919 #36161
@bowei bowei mentioned this pull request Nov 16, 2016
Closed
@bowei bowei changed the title Adds TCPCloseWaitTimeout option to kube-proxy for sysctl nf_conntrack… Adds option to set CLOSE_WAIT timeout from kube-proxy, adjusts default timeout to 1 hour Nov 16, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@jessfraz
Merge pull request kubernetes#36510 from jessfraz/automated-cherry-pi…
875d3fe 
…ck-of-#34375-kubernetes#35285-kubernetes#35420-kubernetes#35608-kubernetes#35919-kubernetes#36161-origin-release-1.4

Automated cherry pick of kubernetes#34375 kubernetes#35285 kubernetes#35420 kubernetes#35608 kubernetes#35919 kubernetes#36161
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@bowei bowei deleted the issue-32551 branch February 21, 2017 19:11
@giner giner mentioned this pull request Jun 16, 2019
Closed
@hanxueluo hanxueluo mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

Assignees

@freehan freehan

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@bowei @k8s-ci-robot @k8s-github-robot @jessfraz @thockin @freehan @googlebot @spxtr @bprashanth @matchstick