Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeadm etcd to 3.0.13 in order to switch to the etcd3 storage format #35921

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Update kubeadm etcd to 3.0.13 in order to switch to the etcd3 storage format #35921

merged 1 commit into from
Nov 29, 2016

Conversation

luxas
Copy link
Member

@luxas luxas commented Oct 31, 2016 •
edited by k8s-oncall
Loading

ref: #35723

I think we should switch as soon as possible, but run it in etcd2 mode until the full etcd3 mode is stable

@kubernetes/sig-cluster-lifecycle @wojtek-t @xiang90 @lavalamp

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 31, 2016
@luxas luxas added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d62609e1da5ff33b2cd11fc9d486a4d2ae95c7e6. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@timothysc timothysc added this to the v1.5 milestone Oct 31, 2016
@timothysc timothysc self-assigned this Oct 31, 2016
@timothysc
Copy link
Member

lgtm.

@timothysc timothysc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2016
@errordeveloper
Copy link
Member

If @timothysc says it's good, I'm happy.

@errordeveloper
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit d62609e1da5ff33b2cd11fc9d486a4d2ae95c7e6. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit d62609e1da5ff33b2cd11fc9d486a4d2ae95c7e6. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@luxas
Copy link
Member Author

luxas commented Nov 1, 2016

It flaked and I'll retrigger soon, but waiting on @wojtek-t to actually push the image...

@luxas luxas removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2016
@errordeveloper
Copy link
Member

IIRC, we said that 2.x is what we should stick to for the moment, but please correct me if I'm wrong. If that is correct, we should probably close this PR. Also, something to consider, we could provide a way for folks to test with 3.0 (i.e. via a version flag, which would probably have to go in the config file).

@luxas
Copy link
Member Author

luxas commented Nov 7, 2016

We just said that we'll wait until the 3.0.13 or 3.0.14 image is pushed == until the k8s etcd team consider etcd3 stable, which will be in time for v1.5. So we'll just defer until they have pushed the image and then merge this in time for v1.5 kubeadm

But yes, we should expose this version in the api as well (I've started working on a such change)

@dims
Copy link
Member

dims commented Nov 10, 2016

@wojtek-t @luxas @errordeveloper : Is this related to the exception being requested in:
https://groups.google.com/d/msg/kubernetes-milestone-burndown/3dBR8PDJcQA/eA41AGrLBAAJ

@luxas luxas removed this from the v1.5 milestone Nov 10, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2016
@luxas luxas added retest-not-required and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2016
@luxas
Copy link
Member Author

luxas commented Nov 21, 2016

Ok, so a 3.0.14 image was now pushed with the -kubeadm suffix that stands for that it's ok to use this image with kubeadm, but not for anything else.

The reason is that GKE won't upgrade to etcd3 for v1.5, so then no final 3.0.14 image should exist.
The only drawback was with upgrade/rollback of existing etcd data which is a problem we do not have with kubeadm, so we can start using etcd3 as the default for new kubeadm clusters now.

cc @wojtek-t @mikedanese @errordeveloper @timothysc

@roberthbailey
Copy link
Contributor

The reason is that GKE won't upgrade to etcd3 for v1.5

The decision was that etcd3 wouldn't be the default in 1.5 for any deployments, not just GKE.

@luxas
Copy link
Member Author

luxas commented Nov 23, 2016

The decision was that etcd3 wouldn't be the default in 1.5 for any deployments, not just GKE.

Ah got it. Anyway, since we're only starting new clusters for the time being, it's okay with etcd3.

@errordeveloper @timothysc Want to give your lgtm?

@luxas luxas added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 25, 2016
This was referenced Nov 25, 2016
Closed
Closed
@luxas
Copy link
Member Author

luxas commented Nov 28, 2016

@mikedanese PTAL and LGTM, this is really straightforward and has been lgtm'd once already

@bgrant0607 bgrant0607 removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 28, 2016
@timothysc
Copy link
Member

So etcd3 was booted from the release, what's the reason for pushing this through?

@luxas
Copy link
Member Author

luxas commented Nov 28, 2016

The reason it didn't make v1.5 was upgrades from existing clusters.
kubeadm doesn't have that problem since we're making new clusters.

It was reported that etcd3 worked well when running it in new clusters.

And if we wait with the etcd upgrade until kubeadm is in beta, we have to deal with the etcd2 => etcd3 upgrade which we can avoid by upgrading now.
WDYT?

@timothysc
Copy link
Member

WDYT?

Is kubeadm still alpha? Then I'm ok with it.

@luxas
Copy link
Member Author

luxas commented Nov 28, 2016

Yes, it's alpha

@timothysc
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 40d5dca into kubernetes:master Nov 29, 2016
@javaboyuk
Copy link

javaboyuk commented Jan 26, 2017 •
edited
Loading

I thought that 3.0.x did not compile/work on ARM kit eg RPI - 3

https://github.com/coreos/etcd/blob/2724c3946eb2f3def5ed38a127be982b62c81779/Documentation/op-guide/supported-platform.md

There is a etcd2 compiled version of etcd but I could not find a etc3 version.

As I understand it this will support ARM this could make that difficult?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timothysc timothysc

@errordeveloper errordeveloper

Labels
area/etcd lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@luxas @k8s-ci-robot @timothysc @errordeveloper @dims @roberthbailey @k8s-github-robot @javaboyuk @googlebot @bgrant0607